Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] stock_split_picking from 10.0 #381

Merged
merged 14 commits into from
Oct 8, 2018
Merged

[9.0] stock_split_picking from 10.0 #381

merged 14 commits into from
Oct 8, 2018

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Oct 19, 2017

No description provided.

@lmignon lmignon changed the title [WIP] [9.0] stock_split_picking from 10.0 [9.0] stock_split_picking from 10.0 Oct 19, 2017
zakiuu
zakiuu approved these changes Oct 19, 2017
View reviewed changes
Copy link
Contributor

@zakiuu zakiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional test

@ThomasBinsfeld
Copy link
Contributor

ping @rousseldenis

@rousseldenis rousseldenis mentioned this pull request Oct 1, 2018
Closed
rousseldenis
rousseldenis approved these changes Oct 1, 2018
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@yvaucher
Copy link
Member

yvaucher commented Oct 1, 2018 •
edited
Loading

I closed #201 in favor of this one.

Don't forget to have a look at #167 to avoid double work.

@pedrobaeza pedrobaeza mentioned this pull request Oct 1, 2018
Closed
34 tasks
@rousseldenis
Copy link
Sponsor Contributor

@yvaucher Done

@LoisRForgeFlow
Copy link
Contributor

This might need a rebase, it is quite old.

@rousseldenis
Copy link
Sponsor Contributor

@lreficent Will do it

@rousseldenis rousseldenis force-pushed the 9.0-mig-stock_split_picking-lmi branch from 79f4ba7 to 90f66ce Compare October 2, 2018 09:45
@rousseldenis
Copy link
Sponsor Contributor

@lreficent Done

LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me if travis goes green

@ThomasBinsfeld
Copy link
Contributor

This one is ready to be merged

@rousseldenis rousseldenis merged commit 3b1bbee into OCA:9.0 Oct 8, 2018
@ThomasBinsfeld ThomasBinsfeld deleted the 9.0-mig-stock_split_picking-lmi branch October 8, 2018 11:24
@pedrobaeza pedrobaeza modified the milestones: 10.0, 9.0 Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakiuu zakiuu zakiuu approved these changes

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

None yet