Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer supplier invoice on dropshipping #48

Merged

Conversation

lepistone
Copy link
Member

fixes odoo/odoo#4131 with a separate addon

Contributors
------------

* Leonardo Pistone <leonardo.pistone@camptocamp.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza
Copy link
Member

Thanks for this very needed feature!

I see as a better name stock_dropshipping_dual_invoice, to follow conventions and short it. What do you think?

Please check Travis error also.

@lepistone
Copy link
Member Author

Thanks as usual for reviewing @pedrobaeza!

The red build is due to stock_route_transit changing the default dropshipping route. Before just isolating the two modules, I'll take a moment to discuss about that with @gurneyalex.

For the title I agree dropshipping_dual_invoice is clearer and shorter, thanks! However I wonder: do we really need to repeat stock_ everywhere? This module, in fact, interacts with sales, purchases, stock and accounting. Moreover, all those modules are already grouped in a repository dealing with stock.

@pedrobaeza
Copy link
Member

Yeah, I agree that we can omit stock_ part, but I put it because the module that starts all of this is called stock_dropshipping, and this way, all related modules are seen together in all lists (module list in Odoo, repository list, and so on).

This module modifies the standard drop shipping route, and other tests
might depend on it. Specifically, those of
stock_dropshipping_dual_invoice.
@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) when pulling 274971a on lepistone:customer_supplier_invoice_on_dropshipping into b30ef17 on OCA:8.0.

@pedrobaeza
Copy link
Member

Thanks!

👍

Otherwise, they are linked to both, which does not make sense.
@lepistone lepistone force-pushed the customer_supplier_invoice_on_dropshipping branch from aaa1069 to 29f1f1b Compare January 21, 2015 09:24
@coveralls
Copy link

Coverage Status

Coverage increased (+5.36%) when pulling 29f1f1b on lepistone:customer_supplier_invoice_on_dropshipping into 1e7938c on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.36%) when pulling 29f1f1b on lepistone:customer_supplier_invoice_on_dropshipping into 1e7938c on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.09%) when pulling d3681a3 on lepistone:customer_supplier_invoice_on_dropshipping into 1e7938c on OCA:8.0.

@gurneyalex
Copy link
Member

👍

gurneyalex added a commit that referenced this pull request Jan 22, 2015
…opshipping

Customer *and* Supplier invoices on dropshipping
@gurneyalex gurneyalex merged commit 5294dfd into OCA:8.0 Jan 22, 2015
@lepistone lepistone deleted the customer_supplier_invoice_on_dropshipping branch January 22, 2015 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants