Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][FIX]stock_cancel. quant cancellation #594

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[10.0][FIX]stock_cancel. quant cancellation #594

merged 1 commit into from
Feb 9, 2022

Conversation

AaronHForgeFlow
Copy link
Contributor

Quant history last move is not always last one.

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Dec 17, 2019
Closed
@AaronHForgeFlow AaronHForgeFlow changed the title [10.0][FIX]stock_cancel. quant cancellation WIP: [10.0][FIX]stock_cancel. quant cancellation Dec 17, 2019
@AaronHForgeFlow
Copy link
Contributor Author

Still not working. Quant history not well kept

@LoisRForgeFlow LoisRForgeFlow added this to the 10.0 milestone Dec 17, 2019
@AaronHForgeFlow AaronHForgeFlow force-pushed the 10.0-fix-stock_cancel branch 3 times, most recently from 5680576 to 7478342 Compare December 17, 2019 14:58
@AaronHForgeFlow
Copy link
Contributor Author

This is now ready for review

@AaronHForgeFlow
Copy link
Contributor Author

@LoisRForgeFlow Could you remove the WIP label? In any case it seems to me there is not much people interesting on thins 😢

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 23, 2022
@rousseldenis
Copy link
Sponsor Contributor

@AaronHForgeFlow What's the status of this ?

@AaronHForgeFlow
Copy link
Contributor Author

@rousseldenis The quant history is incorrect when cancelling stock pickings using the module stock_cancel. IMHO this should be merged to fix that. Nevertheless I don't think many users use that module because of the lack of reviewers here.

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-594-by-rousseldenis-bump-minor, awaiting test results.

@AaronHForgeFlow AaronHForgeFlow changed the title WIP: [10.0][FIX]stock_cancel. quant cancellation [10.0][FIX]stock_cancel. quant cancellation Feb 9, 2022
@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Feb 9, 2022
Closed
@OCA-git-bot OCA-git-bot merged commit bc33b68 into OCA:10.0 Feb 9, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1cf75c6. Thanks a lot for contributing to OCA. ❤️

@AaronHForgeFlow AaronHForgeFlow deleted the 10.0-fix-stock_cancel branch February 9, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AaronHForgeFlow @rousseldenis @OCA-git-bot @LoisRForgeFlow