[FIX] stock_picking_batch_extended: float_is_zero required parameters #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Tecnativa, @camptocamp, |
pedrobaeza
requested review from
rousseldenis and
i-vyshnevska
and removed request for
rousseldenis
pedrobaeza
approved these changes
Dec 18, 2019
|
can you update other calls float_is_zero in this addon |
carlosdauden
force-pushed
the
12.0-fix-stock_picking_batch_extended-float_is_zero
branch
from
f47d0fb
to
f310380
Compare
chienandalu
reviewed
Dec 18, 2019
| return float_is_zero( | ||
| operation.product_qty, | ||
| precision_rounding=operation.product_uom_id.rounding | ||
| ) and operation.qty_done or operation.product_qty |
There was a problem hiding this comment.
Should not be qty_done tested with float_is_zero as well?
chienandalu
approved these changes
Dec 18, 2019
sergio-teruel
approved these changes
Dec 18, 2019
|
@i-vyshnevska is it ok for you? |
i-vyshnevska
approved these changes
Dec 18, 2019
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 18, 2019
|
Congratulations, your PR was merged at c40f5cf. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT18083