[NEW] 360-degree-feedback module #19

mileo · 2016-11-01T05:52:21Z

https://en.wikipedia.org/wiki/360-degree_feedback

coveralls · 2016-11-03T09:54:38Z

Coverage decreased (-4.8%) to 61.572% when pulling 8a2d715 on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

coveralls · 2016-11-03T10:36:07Z

Coverage decreased (-4.8%) to 61.572% when pulling f1732cb on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

coveralls · 2016-11-03T19:34:05Z

Coverage decreased (-4.8%) to 61.572% when pulling 6b46fe2 on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

coveralls · 2016-11-03T19:34:05Z

Coverage decreased (-4.8%) to 61.572% when pulling 6b46fe2 on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

coveralls · 2016-11-03T20:03:18Z

Coverage decreased (-4.8%) to 61.572% when pulling c60401c on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

coveralls · 2016-11-03T20:03:18Z

Coverage decreased (-4.8%) to 61.572% when pulling c60401c on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

coveralls · 2016-11-11T05:25:43Z

Coverage decreased (-4.6%) to 61.739% when pulling 363ae93 on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

coveralls · 2016-11-11T05:25:43Z

Coverage decreased (-4.6%) to 61.739% when pulling 363ae93 on kmee:feature/8.0-360-feedback into 097493d on OCA:8.0.

tarteo

Hey @mileo, please increase coverage, complete the README and remove empty keys in the manifest file.

tarteo · 2016-11-15T09:45:18Z

hr_evaluation_360/__openerp__.py

+        'hr_evaluation'
+    ],
+    'data': [
+    ],


Remove empty keys

coveralls · 2016-11-29T23:08:48Z

Coverage decreased (-5.1%) to 61.207% when pulling 28accd8 on kmee:feature/8.0-360-feedback into abd11f4 on OCA:8.0.

mileo · 2016-11-30T01:43:17Z

Hi, @tarteo No tests add yet, but can be tag as need review.

coveralls · 2016-11-30T01:45:58Z

Coverage decreased (-5.1%) to 61.207% when pulling f999589 on kmee:feature/8.0-360-feedback into abd11f4 on OCA:8.0.

tarteo · 2016-12-05T09:21:54Z

@mileo I'm not authorized to do that.

dreispt · 2016-12-05T14:49:37Z

The linter found a small issue: https://travis-ci.org/OCA/survey/jobs/179964796#L314

dreispt

Thank you for your contribution!
I made a few questions and suggestions.

dreispt · 2016-12-05T14:50:27Z

hr_evaluation_360/README.rst

+
+To use this module, you need to:
+
+#. Go to ...


Go ahead and write something about the Configuration steps to perform, and guide a new user to the steps to use it.

dreispt · 2016-12-05T14:50:51Z

hr_evaluation_360/README.rst

+------------
+
+* Firstname Lastname <email.address@example.org>
+* Second Person <second.person@example.org>


Put your name here 😄

dreispt · 2016-12-05T14:51:52Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+
+    Source: https://en.wikipedia.org/wiki/360-degree_feedback
+
+"""


It's best to move this text into the README

dreispt · 2016-12-05T14:55:51Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+            for phase in evaluation.plan_id.phase_ids:
+                if phase.action != '360':
+                    return super(HrEvaluationEvaluation,
+                                 self).button_plan_in_progress()


You want to perform superon evaluation instead of self.
And on the 360 case, do we really need to completely override/ignore the parent code?

Yes because core implementation set state as waiting withouy any validation

https://github.com/odoo/odoo/blob/8.0/addons/hr_evaluation/hr_evaluation.py#L230

dreispt · 2016-12-05T15:00:47Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+                   [('department_id', '=',
+                     evaluation.employee_id.department_id.id)]
+                )
+                children |= evaluation.employee_id


It would be nice to isolate this children logic into it's own preparation method.
That would make it easier to override/customize this logic.
For example, it could be extended to add Customer you worked to, or to implement some randomization on the final list.

of chieldren methods

coveralls · 2017-01-02T05:32:41Z

Coverage decreased (-5.3%) to 61.044% when pulling 3be59dd on kmee:feature/8.0-360-feedback into 5d76df9 on OCA:8.0.

coveralls · 2017-01-02T05:32:41Z

Coverage decreased (-5.3%) to 61.044% when pulling 3be59dd on kmee:feature/8.0-360-feedback into 5d76df9 on OCA:8.0.

coveralls · 2017-01-03T23:53:59Z

Coverage decreased (-5.3%) to 61.044% when pulling 74f300f on kmee:feature/8.0-360-feedback into 5d76df9 on OCA:8.0.

coveralls · 2017-01-03T23:53:59Z

Coverage decreased (-5.3%) to 61.044% when pulling 74f300f on kmee:feature/8.0-360-feedback into 5d76df9 on OCA:8.0.

dreispt · 2017-01-06T14:15:13Z

@mileo Thinking a bit longer on this, I think this module would be much better hosted in the OCA/hr project.
What do you think?

coveralls · 2017-01-06T14:21:55Z

Coverage decreased (-5.3%) to 61.044% when pulling 53dfcb2 on kmee:feature/8.0-360-feedback into 5d76df9 on OCA:8.0.

coveralls · 2017-01-06T14:21:55Z

Coverage decreased (-5.3%) to 61.044% when pulling 53dfcb2 on kmee:feature/8.0-360-feedback into 5d76df9 on OCA:8.0.

mileo · 2017-01-06T14:26:19Z

@dreispt We are running our first evaluation internally this week. If we do not detect any bug i will make a new PR in hr.

But I'm not intending to add tests for now.

dreispt · 2017-01-06T14:17:52Z

hr_evaluation_360/__openerp__.py

+    'author': 'KMEE,Odoo Community Association (OCA)',
+    'website': 'www.kmee.com.br',
+    'depends': [
+        'hr_evaluation'


This cries out "put in the the hr project!" 😄

dreispt · 2017-01-06T14:21:09Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+                    item.phase_id.action == '360-anonymous'):
+                item.user_id = False
+                item.request_id.partner_id = False
+                item.request_id.email = False


Use a more efficient single write call instead of the three implicit write operations?

Reading it again: why is a constraint validation function performing writes on the data?

dreispt · 2017-01-06T14:25:15Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+        )
+
+    @api.multi
+    def button_plan_in_progress(self):


Is this overriding an hr_evaluation method? We should perform a super() call somewhere in order not to break the inheritance chain.
Also, the logic added is non-trivial enough to deserve a docstring explanation .

dreispt · 2017-01-06T14:27:20Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+
+from openerp import api, fields, models
+
+evaluation_360_list = []


Shouldn't we use uppercase for globals?

dreispt · 2017-01-06T14:31:00Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+
+                children = self.env['hr.employee']
+                for item in evaluation_360_list:
+                    children |= item(self, evaluation)


In a 360 evaluation not every evaluator is an Employee.
AFAIK it is common to ask evaluations from other Partners, such as Customers and Suppliers.

dreispt · 2017-01-06T14:32:13Z

hr_evaluation_360/models/hr_evaluation_plan_phase.py

+                            parser.parse(
+                                datetime.now().strftime('%Y-%m-%d')
+                            ) + relativedelta(months=+1)).strftime(
+                            '%Y-%m-%d'),


Instead of a hardcoded deadline computation, it would be much nicer (and easier) to have this date configured in the Evaluation Plan.

rafaelbn · 2017-05-31T11:32:31Z

Hi @mileo , do you want to continue with this PR? @dreispt made some comments. Let me know please. Thanks

rafaelbn · 2017-05-31T11:35:29Z

Note that we are in the OCA Code Sprint and if runbot, travis are green and test coverage is above 80% you can get this merge today! Thanks!

mileo · 2017-05-31T18:25:48Z

Hi, @rafaelbn

I can´ t continue Today. But we are using in our Odoo in production.

Fell free to review Daniel comments.

Thanks in advance!

github-actions · 2022-04-10T12:27:32Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

mileo force-pushed the feature/8.0-360-feedback branch 2 times, most recently from 068f14c to 8a2d715 Compare November 3, 2016 09:48

mileo force-pushed the feature/8.0-360-feedback branch from 8a2d715 to f1732cb Compare November 3, 2016 10:31

mileo force-pushed the feature/8.0-360-feedback branch from f1732cb to 6b46fe2 Compare November 3, 2016 19:21

mileo force-pushed the feature/8.0-360-feedback branch from 6b46fe2 to c60401c Compare November 3, 2016 19:59

mileo force-pushed the feature/8.0-360-feedback branch from c60401c to 363ae93 Compare November 11, 2016 05:18

tarteo suggested changes Nov 15, 2016

View reviewed changes

hr_evaluation_360/__openerp__.py

'hr_evaluation'

],

'data': [

],

Copy link

Member

tarteo Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty keys

mileo force-pushed the feature/8.0-360-feedback branch from 363ae93 to 28accd8 Compare November 29, 2016 23:05

mileo force-pushed the feature/8.0-360-feedback branch from 28accd8 to f999589 Compare November 30, 2016 01:41

mileo changed the title ~~[WIP][NEW] 360-degree-feedback module~~ [NEW] 360-degree-feedback module Nov 30, 2016

dreispt added the needs review label Dec 5, 2016

dreispt added this to the 8.0 milestone Dec 5, 2016

dreispt reviewed Dec 5, 2016

View reviewed changes

mileo added 2 commits January 2, 2017 03:24

[NEW] 360-degree-feedback module

a8de344

[NEW] Evaluation 360 decotator to isolating logic

17a98c7

of chieldren methods

mileo force-pushed the feature/8.0-360-feedback branch from f999589 to 3be59dd Compare January 2, 2017 05:28

[NEW] Anonymoys 360 feedback

74f300f

mileo force-pushed the feature/8.0-360-feedback branch from 3be59dd to 74f300f Compare January 3, 2017 23:50

Summary in a single line

53dfcb2

dreispt reviewed Jan 6, 2017

View reviewed changes

dreispt mentioned this pull request Jun 1, 2017

Port hr_evaluation from 8.0 to 9.0/10.0 OCA/hr#343

Closed

rafaelbn approved these changes Sep 1, 2019

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2022

github-actions bot closed this May 15, 2022


		Source: https://en.wikipedia.org/wiki/360-degree_feedback

		"""


		from openerp import api, fields, models

		evaluation_360_list = []

[NEW] 360-degree-feedback module #19

[NEW] 360-degree-feedback module #19

Conversation

mileo commented Nov 1, 2016 • edited Loading

coveralls commented Nov 3, 2016 • edited Loading

coveralls commented Nov 3, 2016 • edited Loading

coveralls commented Nov 3, 2016

coveralls commented Nov 3, 2016

coveralls commented Nov 3, 2016

coveralls commented Nov 3, 2016

coveralls commented Nov 11, 2016

coveralls commented Nov 11, 2016

tarteo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 29, 2016 • edited Loading

mileo commented Nov 30, 2016

coveralls commented Nov 30, 2016 • edited Loading

tarteo commented Dec 5, 2016 • edited Loading

dreispt commented Dec 5, 2016

dreispt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 2, 2017

coveralls commented Jan 2, 2017

coveralls commented Jan 3, 2017

coveralls commented Jan 3, 2017

dreispt commented Jan 6, 2017

coveralls commented Jan 6, 2017

coveralls commented Jan 6, 2017

mileo commented Jan 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn commented May 31, 2017

rafaelbn commented May 31, 2017

mileo commented May 31, 2017 • edited Loading

github-actions bot commented Apr 10, 2022

mileo commented Nov 1, 2016 •

edited

Loading

coveralls commented Nov 3, 2016 •

edited

Loading

coveralls commented Nov 3, 2016 •

edited

Loading

coveralls commented Nov 29, 2016 •

edited

Loading

coveralls commented Nov 30, 2016 •

edited

Loading

tarteo commented Dec 5, 2016 •

edited

Loading

mileo commented May 31, 2017 •

edited

Loading