Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0][MIG][survey_one_choice_per_column] #20

Merged
merged 2 commits into from Jun 9, 2017
Merged

[9.0][MIG][survey_one_choice_per_column] #20

merged 2 commits into from Jun 9, 2017

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Nov 4, 2016

No description provided.

@tarteo tarteo mentioned this pull request Nov 4, 2016
Closed
3 tasks
@coveralls
Copy link

coveralls commented Nov 4, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling e3822bb on tarteo:90_mig_survey_one_choice_per_column into 970ffc9 on OCA:9.0.

astirpe
astirpe suggested changes Mar 6, 2017
View reviewed changes
survey_one_choice_per_column/README.rst Outdated
===========

Bugs are tracked on `GitHub Issues
<https://github.com/OCA/200/issues>`_. In case of trouble, please
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should be:
https://github.com/OCA/survey/issues

survey_one_choice_per_column/__init__.py Outdated
@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
# © 2016 Onestein (<http://www.onestein.eu>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the symbol © with Copyright

survey_one_choice_per_column/__openerp__.py Outdated
@@ -0,0 +1,21 @@
# -*- coding: utf-8 -*-
# © 2016 Onestein (<http://www.onestein.eu>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the symbol © with Copyright

survey_one_choice_per_column/models/__init__.py Outdated
@@ -0,0 +1,6 @@
# -*- coding: utf-8 -*-
# © 2016 Onestein (<http://www.onestein.eu>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the symbol © with Copyright

survey_one_choice_per_column/models/survey_question.py Outdated
@@ -0,0 +1,38 @@
# -*- coding: utf-8 -*-
# © 2016 Onestein (<http://www.onestein.eu>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the symbol © with Copyright

survey_one_choice_per_column/models/survey_user_input_line.py Outdated
@@ -0,0 +1,48 @@
# -*- coding: utf-8 -*-
# © 2016 Onestein (<http://www.onestein.eu>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the symbol © with Copyright

survey_one_choice_per_column/tests/__init__.py Outdated
@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
# © 2016 Onestein (<http://www.onestein.eu>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the symbol © with Copyright

survey_one_choice_per_column/tests/test_survey_one_choice_per_column.py Outdated
@@ -0,0 +1,148 @@
# -*- coding: utf-8 -*-
# © 2016 Onestein (<http://www.onestein.eu>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the symbol © with Copyright

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1a9bca2 on tarteo:90_mig_survey_one_choice_per_column into 970ffc9 on OCA:9.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1a9bca2 on tarteo:90_mig_survey_one_choice_per_column into 970ffc9 on OCA:9.0.

@rafaelbn rafaelbn added this to the 9.0 milestone May 31, 2017
@rafaelbn
Copy link
Member

rafaelbn commented Jun 6, 2017

Hi @tarteo , are you going to continue with this PR? Let me know please. Thanks! 😄

astirpe
astirpe approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@tarteo
Copy link
Member Author

tarteo commented Jun 7, 2017

@rafaelbn What do you mean?

rafaelbn
rafaelbn approved these changes Jun 9, 2017
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@rafaelbn rafaelbn merged commit ef10b01 into OCA:9.0 Jun 9, 2017
@tarteo tarteo deleted the 90_mig_survey_one_choice_per_column branch October 30, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astirpe astirpe astirpe approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tarteo @coveralls @rafaelbn @astirpe