Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] survey_question_type_five_star #58

Merged
merged 11 commits into from
Sep 19, 2023
Merged

[16.0] [MIG] survey_question_type_five_star #58

merged 11 commits into from
Sep 19, 2023

Conversation

baimont
Copy link

@baimont baimont commented Oct 4, 2022

#57

@nicolas-tg
Copy link

How can I do functional tests please?

@baimont baimont force-pushed the 16.0-mig-survey_question_type_five_star-bai branch from 79b2710 to e71bf91 Compare January 19, 2023 09:46
xavier-bouquiaux
xavier-bouquiaux reviewed Jan 19, 2023
View reviewed changes
Copy link

@xavier-bouquiaux xavier-bouquiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review tech

survey_question_type_five_star/README.rst Outdated
@@ -35,28 +35,20 @@ This module add five stars rating question type for survey page
Usage
=====

Usage
=====
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runboat in place of runbot please

survey_question_type_five_star/models/survey_user_input_line.py Outdated
@@ -16,7 +16,9 @@ def save_lines(self, question, answer, comment=None):
if question.question_type in ["star_rate"]:
self._save_line_simple_answer(question, old_answers, answer)
else:
super(SurveyUserInput, self).save_lines(question, answer, comment=comment)
return super(SurveyUserInput, self).save_lines(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super() please

@baimont
Copy link
Author

baimont commented Jan 19, 2023

How can I do functional tests please?

Hello @nicolas-tg,
You can use the runboat on this pr.

image

Click on the Details link on runboat/build.

Then you can create a new survey and add a question of type "Five Stars Rating".

image

And test your survey.

image

@xavier-bouquiaux
Copy link

Functionnal review OK

Thanks for the good work

sbejaoui
sbejaoui approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@baimont baimont force-pushed the 16.0-mig-survey_question_type_five_star-bai branch 2 times, most recently from cf1602c to c0c4322 Compare January 19, 2023 10:25
@baimont
Copy link
Author

baimont commented Jan 19, 2023

review tech

Thanks @xavier-bouquiaux !
I adapted the pr.

@baimont baimont force-pushed the 16.0-mig-survey_question_type_five_star-bai branch from c0c4322 to ef550c5 Compare January 19, 2023 10:28
@baimont baimont force-pushed the 16.0-mig-survey_question_type_five_star-bai branch from ef550c5 to 3150b53 Compare January 19, 2023 10:36
xavier-bouquiaux
xavier-bouquiaux approved these changes Jan 19, 2023
View reviewed changes
Copy link

@xavier-bouquiaux xavier-bouquiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseldenis
Copy link
Sponsor

/ocabot migration survey_question_type_five_star

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 19, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 11, 2023
Open
3 tasks
@rousseldenis
Copy link
Sponsor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-58-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 68fd028 into OCA:16.0 Sep 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 89307d4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@apineux apineux apineux approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

@xavier-bouquiaux xavier-bouquiaux xavier-bouquiaux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@baimont @nicolas-tg @xavier-bouquiaux @OCA-git-bot @rousseldenis @gurneyalex @apineux @sbejaoui @olgamarcocb @oca-travis