[16.0][ADD] hr_timesheet_name_customer #568

solo4games · 2023-02-15T13:19:01Z

This module added new field Customer Description in list view In this module in report pdf instead of Description you can see Customer Description. This field can see only Timesheets:Administrator

ivs-cetmix · 2023-02-15T14:06:02Z

hr_timesheet_name_customer/models/hr_timesheet_name_customer.py

+    """override create method, initialize name_customer"""
+
+    @api.model
+    def create(self, vals_list):


Starting Odoo 12 you can create several record and once using create_multi decorator.
Check example here

ivs-cetmix · 2023-02-15T14:08:12Z

hr_timesheet_name_customer/models/hr_timesheet_name_customer.py

+
+    @api.model
+    def create(self, vals_list):
+        if vals_list["name_customer"] is False:


Just do
If not vals.get(“name_customer”):

Because if name_customer is not present in Val’s vals[“name_customer”] will trigger an exception

ivs-cetmix · 2023-02-15T14:12:49Z

hr_timesheet_name_customer/__manifest__.py

+{
+    "name": "Name Customer",
+    "summary": "Add Description Customer",
+    "version": "16.0.0.1.0",


Pleas follow version numbering rules. You can check them here

ivs-cetmix · 2023-02-15T14:14:29Z

hr_timesheet_name_customer/__manifest__.py

+
+{
+    "name": "Name Customer",
+    "summary": "Add Description Customer",


Make description more clear for end user. Eg
“Add ‘Description Customer’ field for timesheets”

ivs-cetmix · 2023-02-15T14:14:57Z

hr_timesheet_name_customer/__manifest__.py

+        "views/hr_timesheet_name_customer_views.xml",
+        "report/name_customer_template.xml",
+    ],
+    "demo": [],


Do not add empty keys. Remove it please

ivs-cetmix · 2023-02-16T09:03:08Z

hr_timesheet_name_customer/__manifest__.py

+{
+    "name": "Name Customer",
+    "summary": "Add ‘Description Customer’ field for timesheets",
+    "version": "16.0.1.0.1",


This is still a release version so 16.0.1.0.0

ivs-cetmix · 2023-02-16T09:07:47Z

hr_timesheet_name_customer/views/hr_timesheet_name_customer_views.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record id="hr_timesheet_name_customer_view" model="ir.ui.view">


Please follow guidelines when for inherited xml ids

ivs-cetmix · 2023-02-16T09:38:19Z

hr_timesheet_name_customer/tests/test_name_customer.py

+        # customer partner
+        cls.partner = cls.env["res.partner"].create(
+            {
+                "name": "Customer Task",


Not the best name for Customer)
It might be misleading

geomer198 · 2023-02-22T15:41:58Z

hr_timesheet_name_customer/tests/test_name_customer.py

+from odoo.tests.common import TransactionCase
+
+
+class TestCommonNameCustomer(TransactionCase):


I think this class you can move to new common.py file and them make import to current file.

geomer198 · 2023-02-22T15:42:28Z

hr_timesheet_name_customer/tests/test_name_customer.py

+
+
+class TestTimesheet(TestCommonNameCustomer):
+    def setUp(self):


You can delete this.

geomer198 · 2023-02-22T15:43:49Z

hr_timesheet_name_customer/views/hr_timesheet_name_customer_views.xml

+        <field name="model">account.analytic.line</field>
+        <field name="inherit_id" ref="hr_timesheet.hr_timesheet_line_tree" />
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='name']" position="after">


You can replace on <field name="name" position="after">...</field>

geomer198

LGTM
PR Name must be have format [verion][ADD] module_name

ivs-cetmix · 2023-02-23T17:18:50Z

hr_timesheet_name_customer/__manifest__.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl-3.0).
+
+{
+    "name": "Name Customer",


Timesheet Description Customer

ivs-cetmix · 2023-02-23T17:21:05Z

hr_timesheet_name_customer/__manifest__.py

+    "application": False,
+    "installable": True,
+    "depends": ["hr_timesheet"],
+    "data": [


Add "maintainers" key with:

CetmixGitDrone

You

See example here

ivs-cetmix · 2023-02-23T20:59:02Z

hr_timesheet_name_customer/readme/USAGE.rst

@@ -0,0 +1,5 @@
+To use this module you need to:
+
+#. Go to Apps and install this module


Modify "Description Customer" field value. Select timesheets you want to print add choose "Timesheets Customer" report.
"Description" column values will be populated from the "Description Customer" field.

ivs-cetmix

LGTM!
please move squash commits and move out of "draft"

OCA-git-bot · 2023-02-25T22:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix · 2023-05-15T13:27:33Z

Hey @OCA/human-resources-maintainers could you please have a look at this?

Saran440

please add license and copyright in python file

example: https://github.com/OCA/timesheet/blob/16.0/hr_timesheet_task_required/models/account_analytic_line.py#LL1

Saran440 · 2023-05-18T02:50:00Z

hr_timesheet_name_customer/README.rst

@@ -0,0 +1 @@
+


please delete this file or generate readme from https://github.com/OCA/maintainer-tools#readme-generator

please delete this file or generate readme from https://github.com/OCA/maintainer-tools#readme-generator

If you delete it then pre-commit will fail. That’s why we are simply adding a file with some placeholder in it. It will be overwritten anyway

please delete this file or generate readme from https://github.com/OCA/maintainer-tools#readme-generator

@Saran440 could you please review its once again? Would be great to have it merged

Saran440 · 2023-06-28T03:50:29Z

Code Reviewed. 👍

please rebase commit into 1 commit.

This module added new field Customer Description in list view In this module in report pdf instead of Description you can see Customer Description. This field can see only Timesheets:Administrator

ivs-cetmix · 2023-06-29T15:37:56Z

Code Reviewed. 👍

please rebase commit into 1 commit.

done

Saran440 · 2023-07-01T08:07:16Z

/ocabot merge nobump

OCA-git-bot · 2023-07-01T08:07:25Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-568-by-Saran440-bump-nobump, awaiting test results.

OCA-git-bot · 2023-07-01T08:13:05Z

Congratulations, your PR was merged at fb3bb70. Thanks a lot for contributing to OCA. ❤️

solo4games marked this pull request as draft February 15, 2023 13:24

ivs-cetmix suggested changes Feb 15, 2023

View reviewed changes

solo4games force-pushed the 16.0-t2358-oca_timesheet-add_customer_description branch from e6b5724 to 3c7b447 Compare February 15, 2023 15:34

ivs-cetmix suggested changes Feb 16, 2023

View reviewed changes

geomer198 reviewed Feb 22, 2023

View reviewed changes

geomer198 approved these changes Feb 22, 2023

View reviewed changes

ivs-cetmix suggested changes Feb 23, 2023

View reviewed changes

ivs-cetmix approved these changes Feb 25, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 25, 2023

solo4games force-pushed the 16.0-t2358-oca_timesheet-add_customer_description branch 3 times, most recently from f617766 to 3786e67 Compare February 26, 2023 20:16

solo4games changed the title ~~[16.0][ADD] hr_timesheet_name_customer:custom desc~~ [16.0][ADD] hr_timesheet_name_customer Feb 26, 2023

solo4games marked this pull request as ready for review February 26, 2023 20:21

Saran440 reviewed May 18, 2023

View reviewed changes

solo4games force-pushed the 16.0-t2358-oca_timesheet-add_customer_description branch 2 times, most recently from 726189c to 10ddf55 Compare June 28, 2023 18:59

[16.0][ADD] hr_timesheet_name_customer:custom desc

53ad149

This module added new field Customer Description in list view In this module in report pdf instead of Description you can see Customer Description. This field can see only Timesheets:Administrator

solo4games force-pushed the 16.0-t2358-oca_timesheet-add_customer_description branch from 10ddf55 to 53ad149 Compare June 28, 2023 19:09

OCA-git-bot added the bot is merging ⏳ label Jul 1, 2023

OCA-git-bot merged commit b922c73 into OCA:16.0 Jul 1, 2023
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] hr_timesheet_name_customer #568

[16.0][ADD] hr_timesheet_name_customer #568

solo4games commented Feb 15, 2023

ivs-cetmix Feb 15, 2023

ivs-cetmix Feb 15, 2023

ivs-cetmix Feb 15, 2023

ivs-cetmix Feb 15, 2023

ivs-cetmix Feb 15, 2023

ivs-cetmix Feb 16, 2023

ivs-cetmix Feb 16, 2023

ivs-cetmix Feb 16, 2023

geomer198 Feb 22, 2023

geomer198 Feb 22, 2023

geomer198 Feb 22, 2023

geomer198 left a comment •

edited

Loading

ivs-cetmix Feb 23, 2023

ivs-cetmix Feb 23, 2023

ivs-cetmix Feb 23, 2023

ivs-cetmix left a comment

OCA-git-bot commented Feb 25, 2023

ivs-cetmix commented May 15, 2023

Saran440 left a comment

Saran440 May 18, 2023

ivs-cetmix May 25, 2023

ivs-cetmix Jun 27, 2023

Saran440 commented Jun 28, 2023

ivs-cetmix commented Jun 29, 2023

Saran440 commented Jul 1, 2023

OCA-git-bot commented Jul 1, 2023

OCA-git-bot commented Jul 1, 2023

		from odoo.tests.common import TransactionCase


		class TestCommonNameCustomer(TransactionCase):



		class TestTimesheet(TestCommonNameCustomer):
		def setUp(self):

		@@ -0,0 +1,5 @@
		To use this module you need to:

		#. Go to Apps and install this module

[16.0][ADD] hr_timesheet_name_customer #568

[16.0][ADD] hr_timesheet_name_customer #568

Conversation

solo4games commented Feb 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geomer198 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivs-cetmix left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 25, 2023

ivs-cetmix commented May 15, 2023

Saran440 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Saran440 commented Jun 28, 2023

ivs-cetmix commented Jun 29, 2023

Saran440 commented Jul 1, 2023

OCA-git-bot commented Jul 1, 2023

OCA-git-bot commented Jul 1, 2023

geomer198 left a comment •

edited

Loading