Improve coverage

membership_variable_period/models/account_invoice.py

@@ -11,7 +11,7 @@ class AccountInvoiceLine(models.Model):
     _inherit = "account.invoice.line"
 
     def _prepare_membership_line(self, invoice, product, price_unit, line_id,
-                                 qty=1):
+                                 qty=1.0):
         qty = int(math.ceil(qty))
         date_from = fields.Date.from_string(
             invoice.date_invoice or fields.Date.today())

membership_variable_period/tests/test_membership_variable_period.py

@@ -169,6 +169,27 @@ def test_modify_invoice_membership_product(self):
         self.assertEqual(membership_lines[0].date_from, '2015-07-01')
         self.assertEqual(membership_lines[0].date_to, '2016-06-30')
 
+    def test_modify_invoice_membership_product_type(self):
+        self.product.membership = False
+        account = self.partner.property_account_receivable_id.id
+        invoice = self.env['account.invoice'].create({
+            'partner_id': self.partner.id,
+            'date_invoice': '2015-07-01',
+            'account_id': account,
+        })
+        self.env['account.invoice.line'].create({
+            'account_id': account,
+            'product_id': self.product.id,
+            'price_unit': self.product.list_price,
+            'name': 'Membership w/o prorrate',
+            'invoice_id': invoice.id,
+            'quantity': 1.0,
+        })
+        self.assertFalse(invoice.invoice_line_ids[0].membership_lines)
+        self.product.membership = True
+        invoice.invoice_line_ids[0].quantity = 1.0
+        self.assertEqual(len(invoice.invoice_line_ids[0].membership_lines), 1)
+
     def test_create_and_modify_invoice_line_membership_product(self):
         account = self.partner.property_account_receivable_id.id
         self.product.membership_interval_qty = 20