[12.0][FIX] membership_delegated_partner: changing delegated member #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astirpe
force-pushed
the
12_fix_membership_delegated_partner
branch
from
e3636d7
to
a17fcef
Compare
chienandalu
requested changes
Nov 21, 2019
chienandalu
reviewed
Nov 21, 2019
astirpe
force-pushed
the
12_fix_membership_delegated_partner
branch
2 times, most recently
from
c137d81
to
c0e6672
Compare
astirpe
changed the title
astirpe
force-pushed
the
12_fix_membership_delegated_partner
branch
from
c0e6672
to
806fd72
Compare
|
@chienandalu Fixed! |
pedrobaeza
approved these changes
Nov 22, 2019
|
@chienandalu would you update your review? |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Nov 29, 2019
|
This PR has the |
|
Congratulations, your PR was merged at 845ea56. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
This PR is also a proposal to use a different approach for calculating the membership lines.The proposal is to use a compute method for the partner in the membership lines.