[FIX] bug: _get_product_price uses wrong pricelist on batches

contract_isp/contract.py

@@ -128,16 +128,21 @@ class contract_service(orm.Model):
     _name = 'contract.service'
 
     def _get_product_price(self, cr, uid, ids, field_name, arg, context=None):
+        # WARNING: This method is called on contract.service lines
+        # belonging to different contracts. We cannot assume that all the
+        # line have the same partner or pricelist. - Jerome 2017/08
         product_pricelist_obj = self.pool.get('product.pricelist')
-        partner_id = self.browse(
-            cr, uid, ids[0],
-            context=context).account_id.partner_id.id
-        pricelist_id = self.browse(
-            cr, uid, ids[0],
-            context=context
-        ).account_id.partner_id.property_product_pricelist.id
         ret = {}
         for line in self.browse(cr, uid, ids, context=context):
+            # Possible optimization: group lines by contract so we don't have
+            # to lookup partner and pricelist for each individual line.
+            partner_id = self.browse(
+                cr, uid, line.id,
+                context=context).account_id.partner_id.id
+            pricelist_id = self.browse(
+                cr, uid, line.id,
+                context=context
+            ).account_id.partner_id.property_product_pricelist.id
             if line.product_id:
                 ret[line.id] = product_pricelist_obj.price_get(
                     cr, uid, [pricelist_id],