[10.0][ADD] medical_agpl: Module for AGPL assets #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasley
changed the title
lasley
force-pushed
the
feature/10.0/medical_agpl
branch
from
5ff7057
to
ca58e2b
Compare
This was referenced May 17, 2017
lasley
force-pushed
the
feature/10.0/medical_agpl
branch
from
ca58e2b
to
2cac446
Compare
JordiBForgeFlow
approved these changes
May 18, 2017
|
@obulkin please review |
|
@lasley - Everything looks fine here, but the module is basically just a skeleton. Is there something missing from the PR, or is the purpose just to install AGPL dependencies? |
|
Also need partner_contact_weight I believe in the depends |
* Add AGPL modules that improve vertical medical
lasley
force-pushed
the
feature/10.0/medical_agpl
branch
from
2cac446
to
07a61b4
Compare
|
@obulkin - the purpose is basically just to bind in AGPL dependencies and provide a clear path for AGPL code to travel in our ecosystem. If anything depends on this, it is an AGPL module. A similar concept can be seen in l10n_us_account_profile. @BMW95 |
|
@lasley - Got it. In that case, everything looks good to me. |
obulkin
approved these changes
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is not necessary for the operation of most of Vertical Medical, but does add some nifty logic that is worth having.
cc @LasLabs @eficent