Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #40: assertion that is always True #122

Merged
merged 2 commits into from
Feb 5, 2015
Merged

Conversation

lepistone
Copy link
Member

Found by pylint, well done pylint!

Found by pylint, well done pylint!
@yvaucher
Copy link
Member

yvaucher commented Feb 5, 2015

raise error(EBADF, 'Bad file descriptor')

error: [Errno 9] Bad file descriptor

This might be caused by werkzeug version

However there is also:

 AssertionError in Python code  (line 114): missing sourced by

So the test you fixed is failing

@yvaucher
Copy link
Member

yvaucher commented Feb 5, 2015

I think this check should be moved as the Cost Estimate must pass in accepted first.

I'll fix that

@yvaucher yvaucher self-assigned this Feb 5, 2015
@yvaucher yvaucher force-pushed the fix-assertion branch 2 times, most recently from 3cad433 to 93fab53 Compare February 5, 2015 13:24
@coveralls
Copy link

Coverage Status

Coverage increased (+15.6%) to 90.2% when pulling 93fab53 on lepistone:fix-assertion into b0b8c99 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.59% when pulling 11dc670 on lepistone:fix-assertion into b0b8c99 on OCA:8.0.

@gurneyalex
Copy link
Member

👍

@lepistone
Copy link
Member Author

thanks @yvaucher! 👍

yvaucher added a commit that referenced this pull request Feb 5, 2015
fix #40: assertion that is always True
@yvaucher yvaucher merged commit b54aa84 into OCA:8.0 Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants