fix: don't set code on PO generated from agreement #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating a purchase order from a framework agreement, the code should be auto-generated from the sequence, and not be equal to the code of the logistic requisition. This bug was already fixed on v7 by Nicolas Bessi. Then for some reason, while porting to v8 I re-enabled a commented out line bringing that back. Now it is deleted for good.
|
👍 |
|
improvement suggestion: lepistone#1 apart from this 👍 |
|
Pulled @gurneyalex's test. Thanks |
|
👍 |
yvaucher
added a commit
that referenced
this pull request
Nov 10, 2014
fix: don't set code on PO generated from agreement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a purchase order from a framework agreement, the code
should be auto-generated from the sequence, and not be equal to the code
of the logistic requisition.
This bug was already fixed on v7 by Nicolas Bessi. Then for some reason,
while porting to v8 I re-enabled a commented out line bringing that
back.
Now it is deleted for good.