Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 Logistics Requisition and Logisitcs Budget UI improvements #30

Merged
merged 20 commits into from
Nov 13, 2014

Conversation

yvaucher
Copy link
Member

@yvaucher yvaucher commented Nov 7, 2014

As changes in both modules are dependent, I do this in one PR to keep travis green

@yvaucher
Copy link
Member Author

yvaucher commented Nov 7, 2014

Included #28 to make travis green

@yvaucher yvaucher changed the title 8.0 Logistics Budget UI improvements 8.0 Logistics Requisition and Logisitcs Budget UI improvements Nov 7, 2014
@lepistone
Copy link
Member

thanks 👍

@yvaucher yvaucher force-pushed the lr-budget-ui-imp branch 2 times, most recently from e1d972e to 74d40a2 Compare November 10, 2014 14:52
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) when pulling ec448e4 on yvaucher:lr-budget-ui-imp into 9fd6a2a on OCA:8.0.

@yvaucher yvaucher force-pushed the lr-budget-ui-imp branch 3 times, most recently from 20f9f62 to 3adbcba Compare November 12, 2014 12:21
@gurneyalex
Copy link
Member

@yvaucher could you rebase?

@lepistone
Copy link
Member

@yvaucher FYI the conflict is in a view.

gurneyalex and others added 3 commits November 13, 2014 13:06
logistic_requisition depends on purchase_requisition_delivery_address
That is needed here because there is no default for that field anymore.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 841ccf9 on yvaucher:lr-budget-ui-imp into * on OCA:8.0*.

the currency_id and company_currency_id fields are not used
and having the company_currency_id field in there (which is a 'related' field
going through the LR of the LR line) was causing problems at creation time in
the web client because the LR does not exist yet and this would cause a write
on res_company setting the currency_id to NULL!
@gurneyalex
Copy link
Member

with my fix, 👍

gurneyalex added a commit that referenced this pull request Nov 13, 2014
8.0 Logistics Requisition and Logisitcs Budget UI improvements
@gurneyalex gurneyalex merged commit c5886fd into OCA:8.0 Nov 13, 2014
@yvaucher yvaucher deleted the lr-budget-ui-imp branch November 13, 2014 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants