-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 Logistics Requisition and Logisitcs Budget UI improvements #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d401404
to
b7400d6
Compare
Included #28 to make travis green |
thanks 👍 |
e1d972e
to
74d40a2
Compare
20f9f62
to
3adbcba
Compare
@yvaucher could you rebase? |
@yvaucher FYI the conflict is in a view. |
replace separators by group
logistic_requisition depends on purchase_requisition_delivery_address
That is needed here because there is no default for that field anymore.
8ec4fa6
to
841ccf9
Compare
Changes Unknown when pulling 841ccf9 on yvaucher:lr-budget-ui-imp into * on OCA:8.0*. |
the currency_id and company_currency_id fields are not used and having the company_currency_id field in there (which is a 'related' field going through the LR of the LR line) was causing problems at creation time in the web client because the LR does not exist yet and this would cause a write on res_company setting the currency_id to NULL!
with my fix, 👍 |
gurneyalex
added a commit
that referenced
this pull request
Nov 13, 2014
8.0 Logistics Requisition and Logisitcs Budget UI improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As changes in both modules are dependent, I do this in one PR to keep travis green