Fix manual create sourcing #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OCA#33. This is due to the fact that with the v8 API the methods that compute function fields are called not only on save, but also as automatic onchanges. In that situation, `self` is not a true record, but a virtual NewId that contains only the values present in the view. That is cool in theory, but in cases like that it can crash because the requisition_id is empty as it is not present in the view. This fix does the computation that relies on requisition_id only when it is available. I do not check explicitly whether self if a NewId, so that if we manage to fix the view so that we know the requisition_id, the amount_total_company will be updated on the fly.
| # instead of crashing. The result of that is that the | ||
| # amount_total_company field will be updated only when we save. | ||
| # It might be that that can be improved by improving the view. This | ||
| # check will pose no problem in that case. |
There was a problem hiding this comment.
should we log something in that case?
There was a problem hiding this comment.
agreed: that should be a warn.
|
@rdeheele @gurneyalex done. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.