Set price of agreement when sourcing with a framework #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
force-pushed
the
8.0-fa_sourcing-set-price
branch
2 times, most recently
from
274e489
to
45bfc84
Compare
|
@yvaucher this needs review or is it WIP? Can you label it please? |
|
@lepistone as travis is failing it is WIP |
gurneyalex
force-pushed
the
8.0-fa_sourcing-set-price
branch
from
45bfc84
to
15e8b69
Compare
|
rebased |
|
with the tests fixed, 👍 |
| @@ -45,7 +45,8 @@ def setUp(self): | |||
| lid = self.requisition_line_model._generate_source_line( | |||
| cr, uid, line) | |||
| source_ids += lid | |||
| self.assertTrue(len(source_ids) == 2) | |||
| self.assertEqual(len(source_ids), 2, | |||
There was a problem hiding this comment.
I don't think we really need to specify failure messages with self.assert* assertions.
Here assertEqual will automatically say, for example, that len(source_ids) is 0 != 2, which is a good failure message.
|
👍 with a minor comment on assertions. |
|
@lepistone fixed |
the PR is about setting the price from the FA on sourcing line, and the tests were correct in the previous version when this was not the case.
yvaucher
force-pushed
the
8.0-fa_sourcing-set-price
branch
from
5921349
to
964e0b2
Compare
lepistone
added a commit
that referenced
this pull request
Nov 19, 2014
Set price of agreement when sourcing with a framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.