make pylint happy #41
Conversation
|
👍 |
| @@ -103,14 +103,14 @@ def create_quotation(test, requisition, lines): | |||
| sale_id = res['res_id'] | |||
| sale = test.env['sale.order'].browse(sale_id) | |||
| sale_lines = sale.order_line | |||
| source_lines = [sl for line in lines for sl in line.source_ids] | |||
| _source_lines = [sl for line in lines for sl in line.source_ids] | |||
There was a problem hiding this comment.
What's the explanation for this? Thank you in advance.
There was a problem hiding this comment.
@tafaRU source_lines is already a method name upper in this file.
I guess that @gurneyalex didn't wanted to break a method signature that could impact other modules.
There was a problem hiding this comment.
with the new pylint config, you get an error because source_lines is shadowing a function with the same name in the file.
I am not happy with the new travis config, but right now, I really need a green build.
There was a problem hiding this comment.
Shadowed variables can result in side effects, so this prevents it. Now it's a pain to greenify all, I agree.
|
Changes Unknown when pulling 540f6ce on gurneyalex:8.0-pylint into * on OCA:8.0*. |
|
👍 Fast tracked! |
|
@yvaucher @gurneyalex @pedrobaeza thanks so much for your explanations! This is what It is called "Power of Community" 💪 and I love it 💚 |
No description provided.