Enforce budget on cost estimate validation #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discussed this with @yvaucher and @rdeheele. These tests are long flows taken from logistic_requisition before logistic_budget was split out, that check functionality of logistic_budget that is not there anymore (we removed the old constraints). We did not notice the problem because the only assertion was disabled to work around a bug in the core, recently fixed. For the new functionality I will not recover these tests, as they are not really relevant here, and add new ones, more isolated.
That way I can read and write only attributes of the real logistic source.
So that it is consistent with the same field on the logistic request. Make a test stricter to drive this change.
lepistone
force-pushed
the
enforce-budget-on-costestimate-validation
branch
from
96c16ee
to
26dddaa
Compare
If some module enables sale exceptions (like logistic_budget), the integration tests of logistic_requisition will fail. Disable the check in the tests, because it is irrelevant to the module.
lepistone
force-pushed
the
enforce-budget-on-costestimate-validation
branch
from
fcf8cef
to
3e124fc
Compare
| A line of a logistic request can have a budget and a pre-approval by a budget | ||
| holder and a finance officer. | ||
|
|
||
| The creation of a cost estimate can be done without approval of with a budget |
|
nice test refactoring work. 👍 once the minor things in the README are fixed. |
|
readme fixed |
|
👍 |
| @@ -0,0 +1,11 @@ | |||
| Logisitic budget | |||
| ================ | |||
|
Note: travis red build seems unrelated: pylint crashes with The last commit changes only the readme, the one before is green. |
|
👍 |
guewen
added a commit
that referenced
this pull request
Nov 24, 2014
…validation Enforce budget on cost estimate validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is intended to bring the enforcement of the budget to the cost estimate validation.
Because cost estimates are... estimates, it is too strict to enforce the budget on the creation (that was disabled already). Instead, we check when the estimate is validated into a logistic order.