Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add budget_tot_price in SO Line form view #72

Merged
merged 4 commits into from
Dec 8, 2014

Conversation

gurneyalex
Copy link
Member

No description provided.

@jgrandguillaume
Copy link
Member

If travis green 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) when pulling 06bf08c on gurneyalex:8.0-budget_amount_on_SO_line into c97843d on OCA:8.0.

@@ -2,6 +2,17 @@
<openerp>
<data noupdate="0">

<record model="ir.ui.view" id="view_order_line_form">
<field name="name">view_order_form</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change view name.

@yvaucher
Copy link
Member

Just one little thing to fix otherwise good.

<field name='model'>sale.order.line</field>
<field name="inherit_id" ref='sale.view_order_line_form2'/>
<field name='arch' type='xml'>
<field name='price_unit' position='after'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want it after price_subtotal field ? s/price_unit/price_subtotal

Float field budget_tot_price seems to indicate we want a budget on the line to limit to be comparable to subtotal and not to be comparable to price_unit

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) when pulling f7e1e2c on gurneyalex:8.0-budget_amount_on_SO_line into c97843d on OCA:8.0.

@lepistone
Copy link
Member

👍 and I'll merge as soon as the remarks by @yvaucher are addressed.

@yvaucher yvaucher removed the question label Dec 4, 2014
@yvaucher
Copy link
Member

yvaucher commented Dec 4, 2014

👍

lepistone added a commit that referenced this pull request Dec 8, 2014
add budget_tot_price in SO Line form view
@lepistone lepistone merged commit bf3e312 into OCA:8.0 Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants