8.0 remove Purchase Requisition creation wizard #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
changed the title
yvaucher
force-pushed
the
8.0-remove-po-req-create-wiz
branch
4 times, most recently
from
e684a12
to
f249c3d
Compare
|
👍 |
| procurement_method = 'procurement' contained | ||
| in the Line | ||
| """ | ||
| source_lines = self.source_ids | ||
| if not source_lines: | ||
| sources = self.mapped('source_ids') |
There was a problem hiding this comment.
why do you use self.mapped('source_ids') instead of self.source_ids? I would understand if self could be a recordset with many records but here it is decorated with @api.one.
There was a problem hiding this comment.
In fact it should be a @api.multi as we want only one po_requisition at the end.
yvaucher
force-pushed
the
8.0-remove-po-req-create-wiz
branch
from
f1ab38e
to
01c984e
Compare
|
@guewen Thanks for the review. Fixed. |
| 'please create one.')) | ||
| pricelist = self.requisition_id.pricelist_id or None | ||
| source_lines._action_create_po_requisition(pricelist=pricelist) | ||
| _('No sourcing line with a Tender procurement ' |
There was a problem hiding this comment.
Still as it is the term in procurement_method Selection field
|
👍 |
1 similar comment
|
👍 |
gurneyalex
force-pushed
the
8.0-remove-po-req-create-wiz
branch
from
01c984e
to
6033124
Compare
The action should be done from LRL or done with a multi selection of LRS
…ding one click for nothing.
yvaucher
force-pushed
the
8.0-remove-po-req-create-wiz
branch
from
6033124
to
e658bc2
Compare
|
👍 |
nbessi
added a commit
that referenced
this pull request
Dec 2, 2014
8.0 remove Purchase Requisition creation wizard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view: Logistics Requisition Line Form
action: Button Create Purchase Requisition on Form
Aim: Create a Single Purchase requisition for all Sources in Tender
view: LR Source List
action: More -> Create Purchase Requisition on Form
Aim: Select precisely which Source you want in same Purchase Requisition