logistic order: more readonly states #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually I am adding a few more similar fixes in this branch. for that reason the WIP label. |
|
...done |
The dependency is the other way round. Duplicate the states, then.
gurneyalex
force-pushed
the
more-readonly-states
branch
from
20579fa
to
a2fd384
Compare
|
this needs review now. Thanks! |
| @@ -30,10 +33,6 @@ | |||
| class logistic_requisition(orm.Model): | |||
| _inherit = "logistic.requisition" | |||
|
|
|||
| REQ_STATES = {'confirmed': [('readonly', True)], | |||
There was a problem hiding this comment.
Are we sur no other addons use this one. Shouldn't we create a local valiable that alias the one in logistic requisition?
There was a problem hiding this comment.
I am not aware of any @nbessi. If there are any we will find out soon enough (that should break on installation) and fix immediately.
There was a problem hiding this comment.
@lepistone never forget that there might be unpublished code or code outside OCA used out there 👅 .
But well I won't consider as blocking
because logistic_order depends on logistic_consignee
lepistone
force-pushed
the
more-readonly-states
branch
from
3e5dadb
to
555cf39
Compare
|
👍 |
yvaucher
added a commit
that referenced
this pull request
Dec 11, 2014
logistic order: more readonly states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.