Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] port module logistic_requistion_budget #9

Merged
merged 9 commits into from
Nov 3, 2014
Merged

[8.0] port module logistic_requistion_budget #9

merged 9 commits into from
Nov 3, 2014

Conversation

yvaucher
Copy link
Member

@yvaucher yvaucher force-pushed the 8.0-logistic_requistion_budget branch 2 times, most recently from 826ad20 to c95f464 Compare October 17, 2014 14:38
@yvaucher yvaucher force-pushed the 8.0-logistic_requistion_budget branch from 739b749 to 03e92cb Compare October 17, 2014 17:06
@gurneyalex
Copy link
Member

Please rename to logistic_budget

@lepistone
Copy link
Member

Code review 👍
Waiting for #8 to test that a bit. Thanks!

@max3903
Copy link
Sponsor Member

max3903 commented Oct 24, 2014

👍

@gurneyalex gurneyalex force-pushed the 8.0-logistic_requistion_budget branch from 8bfbe8d to 9e0495e Compare October 31, 2014 07:37
@yvaucher yvaucher force-pushed the 8.0-logistic_requistion_budget branch 2 times, most recently from 156de8c to 602c752 Compare October 31, 2014 14:56
@yvaucher yvaucher force-pushed the 8.0-logistic_requistion_budget branch 2 times, most recently from c8d92ce to 5158649 Compare November 3, 2014 07:57
@coveralls
Copy link

Coverage Status

Coverage increased (+14.29%) when pulling 5158649 on yvaucher:8.0-logistic_requistion_budget into 5d27e3a on OCA:8.0.

@yvaucher yvaucher force-pushed the 8.0-logistic_requistion_budget branch from 5158649 to 378621e Compare November 3, 2014 08:17
@lepistone
Copy link
Member

@yvaucher I agree with disabling the test, because of an external bug. Could please note somewhere very visible (like the manifest) about that, so that we do not forget to reactivate it if the bug is fixed? thanks!

@yvaucher yvaucher force-pushed the 8.0-logistic_requistion_budget branch from 378621e to e23a095 Compare November 3, 2014 08:27
@yvaucher yvaucher force-pushed the 8.0-logistic_requistion_budget branch from e23a095 to bac9393 Compare November 3, 2014 08:30
@coveralls
Copy link

Coverage Status

Coverage increased (+3.83%) when pulling bac9393 on yvaucher:8.0-logistic_requistion_budget into 5d27e3a on OCA:8.0.

lepistone added a commit that referenced this pull request Nov 3, 2014
@lepistone
Merge pull request #9 from yvaucher/8.0-logistic_requistion_budget
e55651c 
[8.0] port module logistic_requistion_budget
@lepistone lepistone merged commit e55651c into OCA:8.0 Nov 3, 2014
@yvaucher yvaucher deleted the 8.0-logistic_requistion_budget branch November 3, 2014 08:43
@coveralls
Copy link

Coverage Status

Coverage increased (+25.2%) to 100.0% when pulling bac9393 on yvaucher:8.0-logistic_requistion_budget into 5d27e3a on OCA:8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yvaucher @gurneyalex @lepistone @max3903 @coveralls