[13.0] web_tree_dynamic_colored_field: colors attribute removed from tree

[guewen]

I'm migrating web_tree_dynamic_colored_field to 13.0.

In previous versions, we could define a dynamic colors attribute on tree views:

web/web_tree_dynamic_colored_field/demo/res_users.xml

Lines 7 to 9 in 4f00741

	<tree position="attributes">
	<attribute name="colors">color_field: lang</attribute>
	</tree>

In odoo 13.0, the colors attribute has been removed from the rng schema: odoo/odoo@7024f8d#diff-e9acd2f731cc01f302055b6e232df983

I thought we could extend the XML before the rng schema is built in: https://github.com/odoo/odoo/blob/6a420921818d741d48bf873e0a62a220c135fbfa/odoo/tools/view_validation.py#L173-L183
but it would require a cherry-pick and only one module would be able to do this. So it doesn't seem to be a good solution.

Any idea where we could store this in the tree's schema (https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/rng/tree_view.rng) or other idea?

@hbrunn @simahawk

[pedrobaeza]

FYI, now it's done through decoration-{bs_class} (for example, decoration-info option).

Maybe you can store it in a key inside options attribute?

[guewen]

🤦‍♂️ I thought there was no options on the <tree> because I didn't see it in the rng file, but it's in the common rng file. Thanks @pedrobaeza, I'll try this.

[guewen]

Done in d989dbd

[pedrobaeza]

Great, closing this then.

[guewen]

Hmm no, actually the options attribute does not exist on tree 😭

2020-01-10 08:49:30,049 16574 ERROR test odoo.tools.view_validation: <string>:1:0:ERROR:RELAXNGV:RELAXNG_ERR_NOELEM: Expecting an element control, got nothing
2020-01-10 08:49:30,049 16574 ERROR test odoo.tools.view_validation: <string>:1:0:ERROR:RELAXNGV:RELAXNG_ERR_INVALIDATTR: Invalid attribute options for element tree
2020-01-10 08:49:30,049 16574 ERROR test odoo.tools.view_validation: Invalid XML:  Get RNG validator and validate RNG file.

[pedrobaeza]

Ouch

[simahawk]

@guewen what about hacking decoration- handling in ListRenderer?
By default it ignores any option not matching theirs but you could support decoration-color.

[guewen]

The problem is not the the js part but the RelaxNG schema that won't allow to use decoration-color in the <tree> element:

https://github.com/odoo/odoo/blob/7615030fb293356fc5540ba65afa66ff71b207c1/odoo/addons/base/rng/tree_view.rng#L39-L46