[IMP] Change display of m2o link #1041

apollet · 2018-09-19T12:58:32Z

Change display of m2o link in order to not have a full clickable link but just an icon next to it.
The icon shows up only when cursor is on the value.

It prevents from opening the many2one form by accident.

oca-clabot · 2018-09-19T12:58:34Z

Hey @apollet, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Alexandre Pollet (no github login found)

Appreciation of efforts,
OCA CLAbot

apollet · 2018-09-19T13:10:03Z

ping @gurneyalex
Je fais parti d'Akretion maintenant, peux tu valider ma CLA s'il te plait ?
Merci beaucoup

pedrobaeza · 2018-09-19T14:52:45Z

This is a good improvement, but it has several flaws:

Starting of, this is not working on runbot, giving an error on sales orders for example:

TypeError: src.replace is not a function

You put the icon of showing a popup, so if the icon does that, it's changing the behavior, because before it was shown on same target, which also follows normal behavior when you are on read mode. If not, please change the icon to a more indicative one.
On contrary, on edit mode, it would be great to have popup edition instead of same target. If this can be contextual to that mode.
A middle way is to have both buttons (popup or inline) and let decide the user to click on each, but it's not very convenient due to the space used.

bealdav · 2018-09-19T15:47:29Z

@pedro you have the same issue on v10 branch

https://travis-ci.org/OCA/web/jobs/422002544

on web_widget_slick

but you're right it's broken in runbot

tarteo

I really like this change. With the suggestions of @pedrobaeza it will be even better. For the icon I guess https://fontawesome.com/icons/edit?style=regular is a little better (if it opens in the same target).
Can you update the README and up the version in the manifest, please?

I couldn't test the functionality in Runbot.

web_tree_many2one_clickable/static/src/css/m2o_clickable.css

bealdav · 2018-09-20T14:34:56Z

@apollet could you have a look on this bug. You can test in sale.order for example. Thanks

apollet · 2018-09-21T09:03:18Z

I changed the icon.

The suggestions of @pedrobaeza are waaay too hard to do for me :) and i think it's not the original purpose of this module.

For the bug on sale order I think it's not part of my few changes....the OCA/web last build throw the same error...

bealdav · 2018-09-21T09:06:35Z

Thanks a lot @apollet.

Nice improvement

tarteo

I tested it on runbot. When I activate the widget I get this error:

TypeError: src.replace is not a function
Please report this to https://github.com/chjj/marked.
    at Lexer.lex (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/535-1462354/web.assets_backend.js:10926:146)
    at Function.Lexer.lex (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/535-1462354/web.assets_backend.js:10926:93)
    at marked (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/535-1462354/web.assets_backend.js:11047:72)
    at Class._format (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/535-1462354/web.assets_backend.js:11123:802)
    at Class.format (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/535-1462354/web.assets_backend.js:2110:12)
    at Class.render_cell (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/535-1462354/web.assets_backend.js:2075:15)
    at Object.render_cell (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/535-1462354/web.assets_backend.js:2075:237)
    at eval (eval at _render (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/400-57aa053/web.assets_common.js:2950:73), <anonymous>:65:30)
    at Object.foreach (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/400-57aa053/web.assets_common.js:2920:18)
    at Engine.eval (eval at _render (http://3339022-1041-272f7f.runbot1.odoo-community.org/web/content/400-57aa053/web.assets_common.js:2950:73), <anonymous>:45:23)

bealdav · 2018-09-21T09:58:57Z

I tried the module from there
https://github.com/OCA/web/tree/10.0/web_tree_many2one_clickable
and I get this error

Branch v10 is red without this update

TypeError: src.replace is not a function

http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:10936
Traceback:
Lexer.prototype.lex@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:10936:142
Lexer.lex@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:10936:87
marked@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:11057:66
_format@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:11133:802
_format@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:2117:8
OdooClass.extend/</prototype[name]</<@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/400-0b9e04f/web.assets_common.js:3015:556
format@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:2110:7
render_cell@http://3338881-10-0-3ce13b.runbot1.odoo-community.org/web/content/554-2f76bbe/web.assets_backend.js:2075:8

bealdav · 2018-10-18T12:55:30Z

It's now works !

ping @tarteo

tarteo · 2018-10-18T14:15:33Z

@bealdav I still get the error.

apollet · 2018-10-19T07:18:18Z

@tarteo
Have you tried to test this PR outside the OCA Runbot ?
It's not a good thing to install all modules of the branch...if one module break something you can't test other modules.

pedrobaeza · 2019-02-11T19:41:01Z

For me the icon is still not good, as current one is indicating the edition of the record, while it should go to the record, but on read mode. A better icon is IMO https://fontawesome.com/icons/angle-double-right?style=solid

If you change it, I'll try the PR outside runbot and push this PR for being merged and forward-ported.

github-actions · 2022-12-04T12:33:46Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

bealdav · 2022-12-05T09:12:17Z

@apollet could you close please ?
Thanks

github-actions · 2023-04-16T12:29:41Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[IMP] Change display of m2o link

14c5a42

bealdav approved these changes Sep 19, 2018

View reviewed changes

tarteo requested changes Sep 20, 2018

View reviewed changes

web_tree_many2one_clickable/static/src/css/m2o_clickable.css Outdated Show resolved Hide resolved

Change icon + update manifest/readme

272f7f1

tarteo requested changes Sep 21, 2018

View reviewed changes

apollet closed this Oct 18, 2018

apollet reopened this Oct 18, 2018

pedrobaeza mentioned this pull request Oct 22, 2018

[10.0] [IMP] web_tree_many2one_clickable. Default false. #1088

Closed

bealdav mentioned this pull request Feb 11, 2019

[12.0] [MIG] web_tree_many2one_clickable #1162

Closed

pedrobaeza added this to the 10.0 milestone May 9, 2019

Tardo mentioned this pull request May 24, 2019

[12.0][MIG] web_tree_many2one_clickable #1290

Merged

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 4, 2022

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 11, 2022

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 16, 2023

github-actions bot closed this May 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] Change display of m2o link #1041

[IMP] Change display of m2o link #1041

apollet commented Sep 19, 2018

oca-clabot commented Sep 19, 2018

apollet commented Sep 19, 2018

pedrobaeza commented Sep 19, 2018

bealdav commented Sep 19, 2018 •

edited

tarteo left a comment

bealdav commented Sep 20, 2018 •

edited

apollet commented Sep 21, 2018

bealdav commented Sep 21, 2018

tarteo left a comment

bealdav commented Sep 21, 2018

bealdav commented Oct 18, 2018

tarteo commented Oct 18, 2018

apollet commented Oct 19, 2018

pedrobaeza commented Feb 11, 2019

github-actions bot commented Dec 4, 2022

bealdav commented Dec 5, 2022

github-actions bot commented Apr 16, 2023

[IMP] Change display of m2o link #1041

[IMP] Change display of m2o link #1041

Conversation

apollet commented Sep 19, 2018

oca-clabot commented Sep 19, 2018

apollet commented Sep 19, 2018

pedrobaeza commented Sep 19, 2018

bealdav commented Sep 19, 2018 • edited

tarteo left a comment

Choose a reason for hiding this comment

bealdav commented Sep 20, 2018 • edited

apollet commented Sep 21, 2018

bealdav commented Sep 21, 2018

tarteo left a comment

Choose a reason for hiding this comment

bealdav commented Sep 21, 2018

bealdav commented Oct 18, 2018

tarteo commented Oct 18, 2018

apollet commented Oct 19, 2018

pedrobaeza commented Feb 11, 2019

github-actions bot commented Dec 4, 2022

bealdav commented Dec 5, 2022

github-actions bot commented Apr 16, 2023

bealdav commented Sep 19, 2018 •

edited

bealdav commented Sep 20, 2018 •

edited