-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new module 'web_listview_date_range_bar'. #117
Conversation
Adds a new view_mode for list views that adds a date range selection toolbar on top of your list view.
Hey @codingforfun, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Hi @codingforfun, Regards. |
i can confirm that @codingforfun is a contractor to initOS and we have all rights of his work, so this is cover to our company cla |
Yes. Thanks @OSguard. |
I discuss this a couple time and until now the result was that the company CLA is enough (and makes our process more easy). |
@legalsylvain @OSguard current ruling is that ECLA is enough for now for employees, although getting them to sign the CLA is cleaner from a legal pov. The main issue is that people may change companies without the OCA being notified, or issues with people working on their free time and who may not appreciate their contributions being affected by their bosses' CLA. In this specific case, @codingforfun is a contractor, and the situation is different: I cannot link the record in the database to initOS because AFAIK he could be working for another partner in the future and we don't want this to be related to initOS. I see 2 options:
Bonus question: is ntdorova a contractor or a initOS employee ? |
travis red -> needs fixing |
the pull request is from our initOS group. This was my suggestion: company repository + company CLA should be to be separate from changing company or private contributing bonus answer: ntdorova is a employee |
@OSguard : No I'm not agree with that point. Other people out of your company can commit into your repository. (You can accept PR), and it happens often. Other possibility, you can fork another repository improve it, and propose the improved module into OCA. |
i mean: |
'category': '', | ||
'summary': 'Add date range selector bar widget above list view rows.', | ||
'description': """ | ||
Date range selelction toolbar for list view widget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/selelction/selection
Thanks for the contribution. Indeed is a needed feature, but the implementation is a bit akward, needing to change action and overriding search, not allowing to use the date range in more than one field, and so on, so I prefer to go to a more generic module, that allows to search for example in the advanced search by a range when the field is a date. BTW, I let others give their opinion about this. |
@pedrobaeza Thanks for your hints. Maybe you can clarify a bit for me and point me in the right direction.
Actually I thought of this as a feature, because i didn't want to tie this to a hard coded field name. Do you have any other idea? I could think of adding the target field name as an optional attribute to the
This one I don't understand. How should I select using the widget or not once it is installed without specifying the view type in an action? Can you clarify please what should be changed here?
What do you mean exactly? Currently you can filter on everything you like in your overridden version of the search function (it's super generic++ ;-). I don't really understand what you mean by more than one field. |
discussion among the board concluded that this contribution is OK cla-wise |
What's the final conclusion here? Any suggestions how this could be improved? |
[IMP] : improve the way we look for data, taking into account @pedrobaeza remarks [IMP] : add a selector to select the field in which we gonna filter. More details : @see : OCA#117
Hi ! @codingforfun.
I wrote a little test module.
Except that points, very good and usefull work. Thanks a lot ! |
You need to add to the action all the views you would like to have e.g.
This way you can switch to the form view. However the customized tree view is missing an icon/button and it's impossible to switch back. This is still an open issue. I'll look at this and your other points asap. |
Hi @codingforfun. About what @pedrobaeza was saying about implementation : I was thinking about such use :
If previous code is used : But it could be an heavy refactoring of your code. What do you think ? |
Based upon the screenshot (I haven't tested this module) : this seems a functional duplicate of #227 (which I have tested intensively in the meanwhile and this one works ok). |
Hi @luc-demeyer ! Thanks for your review. But 'web_tree_date_search' doesn't exist in 7.0 serie and does'nt seem to be backported in 7.0. @codingforfun what do you think ? regards. |
So we have two diffrent version #132 is also related! |
About this PR, anyone interested? I personally preferred something that doesn't any change in views and that is embedded in the advanced search or at least an approach like the one in https://github.com/OCA/web/tree/8.0/web_search_datetime_completion |
Syncing from upstream OCA/web (10.0)
No answer, so I close it. Feel free to reopen if needed. |
[FIX] BQL, BDL fields in project analysis report BSMTS-230
Fwd from 14 to 15 220623 01
Adds a new view_mode for list views that adds a date range selection toolbar on top of your list view.