Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] web_widget_color: Allow non-required fields #1270

Merged
merged 1 commit into from Jul 15, 2020
Merged

[12.0][IMP] web_widget_color: Allow non-required fields #1270

merged 1 commit into from Jul 15, 2020

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented May 3, 2019

This PR adds support to non-required fields (model & view)

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 5, 2019
@Tardo
Copy link
Member Author

Tardo commented Feb 6, 2020

@OCA/web-maintainers

simahawk
simahawk approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm out of ctx and cannot test it. Code review: LG.

@Tardo
Copy link
Member Author

Tardo commented Feb 7, 2020

HI @simahawk thanks for the review....
This PR allow to set the color field as required=0, currently you can't use a non-required field with the color widget, it always expect a value.

jarroyomorales
jarroyomorales approved these changes Jul 15, 2020
View reviewed changes
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1270-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e81e235. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 8a3e77d into OCA:12.0 Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@jarroyomorales jarroyomorales jarroyomorales approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Tardo @OCA-git-bot @pedrobaeza @simahawk @jarroyomorales