Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_responsive: usable search buttons in md screens #1503

Conversation

yajo
Copy link
Member

@yajo yajo commented Jan 27, 2020

When the screen wasn't small enough to trigger mobile mode but wasn't big enough to display properly search buttons, those got awkward.

Before:
2020-01-27_11-58

After:
Peek 27-01-2020 11-59

@Tecnativa TT21728

When the screen wasn't small enough to trigger mobile mode but wasn't big enough to display properly search buttons, those got awkward.

@Tecnativa TT21728
@yajo yajo self-assigned this Jan 27, 2020
@yajo yajo added the bug label Jan 27, 2020
@yajo yajo added this to the 12.0 milestone Jan 27, 2020
@pedrobaeza
Copy link
Member

Why the searchbar needs 2 lines in a moment where it doesn't seem to need it (or you can hide "Search..." text or the carets)?

@yajo
Copy link
Member Author

yajo commented Jan 27, 2020

It's the size where mobile mode triggers in. Needs F5 to render it fully operational.

@pedrobaeza pedrobaeza requested a review from Tardo January 27, 2020 17:05
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1503-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 27, 2020
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

Please move it to 13.0 as well.

@OCA-git-bot OCA-git-bot merged commit 378c02c into OCA:12.0 Jan 27, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7f47987. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants