Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][ADD] web_view_calendar_list #1512

Merged
merged 1 commit into from
Jul 14, 2020
Merged

[11.0][ADD] web_view_calendar_list #1512

merged 1 commit into from
Jul 14, 2020

Conversation

etobella
Copy link
Member

@etobella etobella commented Feb 3, 2020

This module adds a new view type that can be used to show calendars as lists.

Usage

Create a new view using the calendar_list tag.
It has the same options than calendar::

<calendar_list date_start="schedule_date" date_delay="duration" color="partner_id">
    <field name="display_name"/>
    <field name="partner_id"/>
</calendar_list>

image

@jarroyomorales @JordiBForgeFlow

@etobella etobella force-pushed the 11.0-add-web_view_calendar_list branch from 3bbd78c to 1f1bb84 Compare February 3, 2020 16:27
AdriaGForgeFlow
AdriaGForgeFlow approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 👍

web_view_calendar_list/static/src/js/calendar_list_renderer.js Show resolved Hide resolved
jarroyomorales
jarroyomorales approved these changes Feb 20, 2020
View reviewed changes
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member Author

etobella commented Jul 9, 2020

@OCA/web-maintainers

simahawk
simahawk requested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etobella nice addition, thanks!
A bunch of comments on my side 😜

web_view_calendar_list/static/src/js/calendar_list_renderer.js Show resolved Hide resolved
web_view_calendar_list/static/src/js/calendar_list_renderer.js Show resolved Hide resolved
web_view_calendar_list/views/webclient_templates.xml Outdated Show resolved Hide resolved
@etobella etobella force-pushed the 11.0-add-web_view_calendar_list branch from 1f1bb84 to 0a6f27d Compare July 13, 2020 10:16
@simahawk
Copy link
Contributor

@etobella can you check the builds?

@etobella etobella force-pushed the 11.0-add-web_view_calendar_list branch from 0a6f27d to 40b1bf0 Compare July 14, 2020 07:36
@etobella
Copy link
Member Author

Sorry, a misspell now it should be 🍏

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-1512-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bd0514a into OCA:11.0 Jul 14, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1bd5342. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

@jarroyomorales jarroyomorales jarroyomorales approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@etobella @OCA-git-bot @simahawk @AdriaGForgeFlow @jarroyomorales