New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][ADD] web_pivot_computed_measure #1547
[12.0][ADD] web_pivot_computed_measure #1547
Conversation
@ged-odoo I think this is something that is going to interest you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi.
I tried again your module, and in a different way, the loading of the computed measures from the context is not done properly.
Step to reproduce :
Well, this is a bit out of scope, as the initial intention is not to load that computed measures from the context. @Tardo check a bit if it's simple to be done, but if not, we will just annotate that on the known issues. |
Well, that is not the use case proposed by this module, but this is exactly the intention of this module, as the context is the tools used by this module to save and restore computed measures. ;-)
|
As said, if easy to be added, we'll do it. If not, we have set the base, other contributors can add that support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pleasure to read your JS code, 👏 👏
Please remove some 🗑️, and one DIV/0 question.
web_pivot_computed_measure/static/src/xml/web_pivot_computed_measure.xml
Show resolved
Hide resolved
web_pivot_computed_measure/static/src/xml/web_pivot_computed_measure.xml
Outdated
Show resolved
Hide resolved
web_pivot_computed_measure/static/src/xml/web_pivot_computed_measure.xml
Outdated
Show resolved
Hide resolved
9be67e9
to
48a69be
Compare
Thanks for comments and reviews! ❤️ @legalsylvain i can't reproduce your issue :/ |
@Tardo : thanks a lot for your screenshot. indeed, there is no bug in your module. my context was wrong. (forgot |
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
This PR has the |
- Integer | ||
- Float | ||
- Percentage (value * 100) | ||
- Formula*: Custom operation formula |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always visible?
Congratulations, your PR was merged at 2a4b3a6. Thanks a lot for contributing to OCA. ❤️ |
Adds support for computed measures on the pivot view.
Go to pivot view and click on the "Measures" menu, you will see a new option called 'Computed Measure'.
These measures can be mixed and save as favorite.
cc @Tecnativa TT22499