Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] New module web_disable_browser_autocomplete #1623

Merged
merged 1 commit into from Jan 31, 2021
Merged

[12.0][ADD] New module web_disable_browser_autocomplete #1623

merged 1 commit into from Jan 31, 2021

Conversation

renatonlima
Copy link
Member

This module allows you to disable the autocomplete function of the web browser for Odoo input fields.

@renatonlima renatonlima force-pushed the 12.0-web_disable_browser_autocomplete branch from b497c3e to a5e4cd9 Compare June 17, 2020 20:17
legalsylvain
legalsylvain reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi renato.

Thanks for your contribution.

Some questions inline.

Regards.

web_disable_browser_autocomplete/tests/__init__.py Outdated
@@ -0,0 +1,2 @@
# Copyright (C) 2020 Renato Lima - Akretion
# License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove useless files ? Test, readme section...

web_disable_browser_autocomplete/static/src/xml/base.xml
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<templates id="template" xml:space="preserve">
<t t-extend="web.datepicker">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i understand correctly, the auto complet will be disabled only for date field ? Is it normal ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renatonlima resolve this from @legalsylvain please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain,

Correcty in this PR disable only for date fields, my original idea was disable for all input fields, but I don't found a way to do this, Do you have any suggestions for that?

marcelsavegnago
marcelsavegnago approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test Ok. And i was feeling the need for something like this in date type fields.
Thanks

@tarteo tarteo added this to the 12.0 milestone Jul 21, 2020
tarteo
tarteo approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes finally, this was an annoyance for years. Would be nice if this is also fixed on odoo/master
Please look at the comments of @legalsylvain

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gfcapalbo
Copy link

@renatonlima Just remove /tests/init and empty readme stuff for cleanliness and i would be happy to merge this.

@renatonlima renatonlima force-pushed the 12.0-web_disable_browser_autocomplete branch 2 times, most recently from 7ae6748 to 2f4a20a Compare January 28, 2021 21:15
@renatonlima
Copy link
Member Author

@gfcapalbo and travis is green

legalsylvain
legalsylvain requested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcty in this PR disable only for date fields, my original idea was disable for all input fields, but I don't found a way to do this, Do you have any suggestions for that?

could you just add a text in the roadmap section. for the time being the description is not correct. says that disable autocomplete, but in fact only for date field.

otherwise, LGTM .Thanks !

@renatonlima renatonlima force-pushed the 12.0-web_disable_browser_autocomplete branch from 2f4a20a to a7e287e Compare January 28, 2021 23:18
@renatonlima
Copy link
Member Author

@legalsylvain Done, Thanks for your review!

@rvalyi
Copy link
Member

rvalyi commented Jan 29, 2021

@gfcapalbo could you merge?

@marcelsavegnago
Copy link
Member

ping @OCA/web-maintainers

@legalsylvain
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1623-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c40d621 into OCA:12.0 Jan 31, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4e45f6a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovnicraft ovnicraft ovnicraft left review comments

@legalsylvain legalsylvain legalsylvain approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@tarteo tarteo tarteo approved these changes

@AntoniRomera AntoniRomera AntoniRomera approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@renatonlima @OCA-git-bot @gfcapalbo @rvalyi @marcelsavegnago @legalsylvain @ovnicraft @tarteo @AntoniRomera