Migrate web_easy_switch_company to the last v8 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdilHoumadi
commented
Jul 15, 2014
AdilHoumadi
commented
- change route in controller
- adapt the JS to call the backend
- modify the css to graft the widget in the toolbar
- change route in controller - adapt the JS to call the backend - modify the css to graft the widget in the toolbar
|
please fix the minor flake8 errors as indicated above |
added 2 commits
July 17, 2014 22:41
./web_easy_switch_company/controllers/main.py:26:1: E302 expected 2 blank lines, found 1 ./web_easy_switch_company/controllers/main.py:32:9: F841 local variable 'context' is assigned to but never used ./web_easy_switch_company/controllers/main.py:36:1: W391 blank line at end of file
|
Thank! Two last requests: Please remove the module from unported and also remove placeholder, which only served to make travis run (it chokes on empty addons paths) |
- The first module is here so we need to remove the placeholder folder
|
👍 |
|
You have to change icon path from /static/src/img to /static/description in order to get displayed. |
|
The rest of the module LGTM. We still have logo from other companies issue, but I can't imagine any solution. I will push my thumb up when you do this change. Regards. |
|
👍 Thanks |
pedrobaeza
added a commit
that referenced
this pull request
Jul 26, 2014
[MIG] web_easy_switch_company
|
👍 |
leemannd
pushed a commit
to camptocamp/web
that referenced
this pull request
May 29, 2018
Remove VERSION for the .dockerignore file
vrenaville
pushed a commit
to camptocamp/web
that referenced
this pull request
Jul 19, 2018
Use camptocamp/odoo-project:10.0-2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.