Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [MIG] web_no_bubble migration to 14.0 #1845

Merged
merged 14 commits into from Jun 11, 2021
Merged

[14.0] [MIG] web_no_bubble migration to 14.0 #1845

merged 14 commits into from Jun 11, 2021

Conversation

ellbristow
Copy link
Contributor

Pushed wrong branch in #1839

Second attempt

Added: Apply no_bubble template to frontend web editor as well as backend

@ellbristow ellbristow mentioned this pull request Mar 9, 2021
Closed
dsolanki-initos
dsolanki-initos approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good to me.

@dsolanki-initos
Copy link
Contributor

Hi @ellbristow it would be great you can ask someone to add review to get merge thi PR soon.

@dsolanki-initos
Copy link
Contributor

@ALL can somone please review the PR so that we can merge it ASAP

@dsolanki-initos
Copy link
Contributor

@OCA/web-maintainers can somone review the code and merge the PR?

BT-aestebanez
BT-aestebanez approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@BT-aestebanez BT-aestebanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dsolanki-initos
Copy link
Contributor

It would be great if maintainers could merge the PR, Hence it is approved.

@dsolanki-initos
Copy link
Contributor

It would be great if maintainers could merge the PR.
Thank you in Advance!

@dsolanki-initos
Copy link
Contributor

It would be great if maintainers could merge the PR.

@dsolanki-initos
Copy link
Contributor

@OCA/web-maintainers can you please merge this PR?

@dsolanki-initos
Copy link
Contributor

It would be great if the mainainers merge the PR.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1845-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4e55607 into OCA:14.0 Jun 11, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0d0355d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-aestebanez BT-aestebanez BT-aestebanez approved these changes

@dsolanki-initos dsolanki-initos dsolanki-initos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ellbristow @dsolanki-initos @OCA-git-bot @pedrobaeza @BT-aestebanez @oihane @oca-travis @Tardo @BT-nstuder @claudiagn