-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] web list view general buttons #1846
base: 14.0
Are you sure you want to change the base?
Conversation
Add buttons in list view.
Add buttons in list view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this module ?
thanks.
This PR has the |
/ocabot merge patch |
Sorry @dhongu you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@OCA/web-maintainers Can somebody merge this, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! some suggestions...
@@ -0,0 +1,2 @@ | |||
# © 2018 Terrabit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# © 2018 Terrabit | |
# Copyright 2018 Terrabit |
@@ -0,0 +1,17 @@ | |||
# © 2018 Terrabit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# © 2018 Terrabit | |
# Copyright 2018 Terrabit |
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
var self = this; | ||
if (this.context.general_buttons === "get_general_buttons") { | ||
this._rpc({ | ||
model: this.modelName, | ||
method: "get_general_buttons", | ||
args: [this.context.active_id], | ||
context: this.context, | ||
}).then(function (result) { | ||
self.headerGeneralButtons = result; | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var self = this; | |
if (this.context.general_buttons === "get_general_buttons") { | |
this._rpc({ | |
model: this.modelName, | |
method: "get_general_buttons", | |
args: [this.context.active_id], | |
context: this.context, | |
}).then(function (result) { | |
self.headerGeneralButtons = result; | |
}); | |
} | |
if (this.context.general_buttons === "get_general_buttons") { | |
this._rpc({ | |
model: this.modelName, | |
method: "get_general_buttons", | |
args: [this.context.active_id], | |
context: this.context, | |
}).then((result) => { | |
this.headerGeneralButtons = result; | |
}); | |
} |
var el = event.target; | ||
var self = this; | ||
self._rpc({ | ||
model: $(el).attr("model"), | ||
method: $(el).attr("action"), | ||
args: [self.context.active_id], | ||
context: self.context, | ||
}).then(function (result) { | ||
return self.do_action(result); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var el = event.target; | |
var self = this; | |
self._rpc({ | |
model: $(el).attr("model"), | |
method: $(el).attr("action"), | |
args: [self.context.active_id], | |
context: self.context, | |
}).then(function (result) { | |
return self.do_action(result); | |
}); | |
const $el = $(event.target); | |
self._rpc({ | |
model: $el.attr("model"), | |
method: $el.attr("action"), | |
args: [this.context.active_id], | |
context: this.context, | |
}).then((result) => this.do_action(result)); |
Module name shouldn't contain plurals |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.