Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] update readme and add translation status widget #1869

Merged
merged 1 commit into from
Aug 11, 2021
Merged

[14.0][IMP] update readme and add translation status widget #1869

merged 1 commit into from
Aug 11, 2021

Conversation

marcelsavegnago
Copy link
Sponsor Member

No description provided.

@marcelsavegnago
Copy link
Sponsor Member Author

ping @OCA/web-maintainers

@yvaucher
Copy link
Member

@sbidoul shall we update https://github.com/OCA/web/blob/14.0/.copier-answers.yml when we update the readme?

It's seems README.md is not overwritten on next update but I'm not sure it's intended.

yvaucher
yvaucher reviewed Apr 14, 2021
View reviewed changes
README.md
<!-- prettier-ignore-end -->
Translation Status
------------------
[![Translation status](https://translation.odoo-community.org/widgets/web-12-0/-/multi-auto.svg)](https://translation.odoo-community.org/engage/web-12-0/?utm_source=widget)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you already have a badge for this in the new template:

[![Translation Status](https://translation.odoo-community.org/widgets/web-14-0/-/svg-badge.svg)](https://translation.odoo-community.org/engage/web-14-0/?utm_source=widget)

yvaucher
yvaucher reviewed Apr 14, 2021
View reviewed changes
README.md Outdated
Comment on lines 8 to 9
Web addons for Odoo
===================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to put it in there too:
https://github.com/OCA/web/blob/14.0/.copier-answers.yml#L10

Let's also keep the # for title levels, it's easier to maintain.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yvaucher done

@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1869-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 60510cd. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 60510cd into OCA:14.0 Aug 11, 2021
@marcelsavegnago marcelsavegnago deleted the 14-add-translation-status branch August 11, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvaucher yvaucher yvaucher approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcelsavegnago @yvaucher @OCA-git-bot