[IMP] web_widget_bokeh_chart: Upgrade library version #1905
Conversation
There was a problem hiding this comment.
I think this custom css needs to be removed. From my testing I had issues with them and the fixes they were doing are no longer needed as everything is displayed correctly out of the box.
|
Sure! |
etobella
force-pushed
the
14.0-imp-bokeh
branch
from
738a0ce
to
4728db9
Compare
|
/ocabot merge nobump |
|
Sorry @LoisRForgeFlow you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
| @@ -6,13 +6,13 @@ | |||
| "category": "Hidden", | |||
| "summary": "This widget allows to display charts using Bokeh library.", | |||
| "author": "ForgeFlow, " "Odoo Community Association (OCA)", | |||
| "version": "14.0.1.0.0", | |||
| "version": "14.0.2.3.1", | |||
| "maintainers": ["LoisRForgeFlow"], | |||
There was a problem hiding this comment.
I think the problem might be from the change on requirements.txt.
😢
| @@ -6,13 +6,13 @@ | |||
| "category": "Hidden", | |||
| "summary": "This widget allows to display charts using Bokeh library.", | |||
| "author": "ForgeFlow, " "Odoo Community Association (OCA)", | |||
| "version": "14.0.1.0.0", | |||
| "version": "14.0.2.3.1", | |||
There was a problem hiding this comment.
I put this version as the installed version of bokeh is 2.3.1. WDYT?
There was a problem hiding this comment.
Yes, I saw it and I like it 😉
|
@OCA/website-maintainers Can someone merge this? I am maintainer of the module but since the PR is modifying the requirements.txt the bot doesn't obey me. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0a0fe92. Thanks a lot for contributing to OCA. ❤️ |
@LoisRForgeFlow
This intends to upgrade the library.
Tested with OCA/reporting-engine#506