[IMP] web_responsive: Automatic height for HTML fields #1921
Conversation
| @@ -13,7 +13,7 @@ | |||
| "license": "LGPL-3", | |||
| "installable": True, | |||
| "depends": [ | |||
| 'web', | |||
| 'web_editor', | |||
There was a problem hiding this comment.
web_editor is auto_install, so it should be installed, I don't know if this is a problem for web_responsive
There was a problem hiding this comment.
Well, changing dependencies is not the ideal indeed...
There was a problem hiding this comment.
I personally don't like this feature here.
This is how vanilla Odoo 12 looks like:
Peek.06-05-2021.09-12.mp4
Mouse-wheel scrolling feels natural to me. Also, html widgets have a handle at the bottom that allow resizing if the user feels the need for more space.
Adding this option might make other modules depend on web_responsive to be able to make use of automatic_summernote_height, which is not something we desire, because then that'd make the modules not work in enterprise versions for example.
I think this fits better in a more specific module such as web_field_html_customizable, which can be used with web, web_responsive or web_enterprise, and which covers a specific need and can be extended to support further summernote customizations.
Sorry because I'm late to the party, but my vote is 👎🏼 here 🤷🏼♂️
|
Sure!!! I knew that might be an issue, so don't worry, I will close this PR and make a new one with the new module. Thanks for all the comments |
|
Thanks for your contribution and your understanding 😊 |
Following comments from #1919
@SplashS @Tardo @pedrobaeza