-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][WIP] Add float head in tree view #247
Conversation
return $table.closest('.wrapper'); | ||
} | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code works in javascript console, but obviously is not correctly called
Hi @amoya-dx, Intererested feature indeed. I have no idea why the function is not correctly called. I'll take a look during this week. kind regards. |
BTW, did you take a look on #133 ? |
I was looking for this functionality but did not seen this PR before. I will take a look this PR |
Display float head in tree view | ||
===================================== | ||
|
||
This module set head as float in tree view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description is cryptic.
Can you elaborate so that we can improve it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, work is in progess.
Best: This module sets the header always visible in the tree view .
**/ | ||
init: function(parent, dataset, view_id, options) { | ||
var self = this; | ||
self._super(parent, dataset, view_id, options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should modify your code to only call the plugin once the widget is rendered. Can you try with this code?
init: function(parent, dataset, view_id, options) {
var self = this;
self._super(parent, dataset, view_id, options);
self.on("list_view_loaded", self, function() {
var $table = self.$el.find("table.oe_list_content");
$table.floatThead({
scrollContainer: function($table){
return $table.closest('.wrapper');
}
});
},
no tested...
I tried in V8 but it doesn't work event after fix the js bug. Is it working for you ? |
Any update on this? |
@angelmoya, are you going to work on this anytime or should I close it? |
I'm trying to set float head in tree view.
I'm ussing this javascript lib: http://mkoryak.github.io/floatThead/
I just created an Issue, #246