Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][WIP] Add float head in tree view #247

Closed
wants to merge 8 commits into from
Closed

[8.0][WIP] Add float head in tree view #247

wants to merge 8 commits into from

Conversation

angelmoya
Copy link
Member

I'm trying to set float head in tree view.

I'm ussing this javascript lib: http://mkoryak.github.io/floatThead/

I just created an Issue, #246

return $table.closest('.wrapper');
}
});
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code works in javascript console, but obviously is not correctly called

@legalsylvain
Copy link
Contributor

Hi @amoya-dx,

Intererested feature indeed. I have no idea why the function is not correctly called. I'll take a look during this week.

kind regards.

@legalsylvain
Copy link
Contributor

BTW, did you take a look on #133 ?

@angelmoya
Copy link
Member Author

I was looking for this functionality but did not seen this PR before. I will take a look this PR

Display float head in tree view
=====================================

This module set head as float in tree view.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is cryptic.
Can you elaborate so that we can improve it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, work is in progess.

Best: This module sets the header always visible in the tree view .

**/
init: function(parent, dataset, view_id, options) {
var self = this;
self._super(parent, dataset, view_id, options);
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should modify your code to only call the plugin once the widget is rendered. Can you try with this code?

init: function(parent, dataset, view_id, options) {
     var self = this;
     self._super(parent, dataset, view_id, options);
     self.on("list_view_loaded", self, function() {
        var $table = self.$el.find("table.oe_list_content");
        $table.floatThead({
            scrollContainer: function($table){
                return $table.closest('.wrapper');
            }
        });
     },

no tested...

@fossoult
Copy link

I tried in V8 but it doesn't work event after fix the js bug. Is it working for you ?

@pedrobaeza
Copy link
Member

Any update on this?

@pedrobaeza
Copy link
Member

@angelmoya, are you going to work on this anytime or should I close it?

@pedrobaeza pedrobaeza closed this Oct 20, 2016
@pedrobaeza pedrobaeza reopened this Oct 20, 2016
@angelmoya angelmoya closed this Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants