Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] easy_web_export : migration to 8.0 #27

Merged
merged 7 commits into from
Aug 11, 2014
Merged

[IMP] easy_web_export : migration to 8.0 #27

merged 7 commits into from
Aug 11, 2014

Conversation

AdilHoumadi
Copy link

  • Adapt controller
  • move module from unported directory
  • add a view file to attach js to backend assets

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.43%) when pulling 434e119 on taktik:8.0-web_export_view into 529e7cb on OCA:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.43%) when pulling aa05cfd on taktik:8.0-web_export_view into 529e7cb on OCA:master.

rvalyi
rvalyi reviewed Jul 26, 2014
View reviewed changes
web_export_view/static/src/js/web_export_view.js

var _t = instance.web._t,
QWeb = instance.web.qweb;
QWeb = instance.web.qweb;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation here

@rvalyi
Copy link
Member

rvalyi commented Jul 26, 2014

seems good apart from that one line badly indented in web_export_view.js

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.43%) when pulling 291f122 on taktik:8.0-web_export_view into 529e7cb on OCA:master.

eLBati
eLBati reviewed Jul 28, 2014
View reviewed changes
web_export_view/__openerp__.py
# Copyright (C) 2012 Domsense srl (<http://www.domsense.com>)
# Copyright (C) 2012-2013 Agile Business Group sagl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the removal of 2013?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry copy paste from this file which does not contains the same header :
https://github.com/taktik/web/blob/8.0-web_export_view/web_export_view/__init__.py
I'll fix that.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.43%) when pulling 01872a5 on taktik:8.0-web_export_view into 529e7cb on OCA:master.

@hbrunn
Copy link
Member

hbrunn commented Aug 11, 2014

👍

hbrunn added a commit that referenced this pull request Aug 11, 2014
@hbrunn
Merge pull request #27 from taktik/8.0-web_export_view
79112e8 
[IMP] easy_web_export : migration to 8.0
@hbrunn hbrunn merged commit 79112e8 into OCA:master Aug 11, 2014
@LeartS
Copy link

LeartS commented Sep 9, 2014

Can I ask where did you find out the new way of adding static files? Is there any documentation?
I spent a long wondering why my web module wasn't being loaded, I was trying to do as we did in v7:

'js': ['static/src/js/myfile.js']

in __openerp__.py

@AdilHoumadi
Copy link
Author

@LeartS you can check this file :
https://github.com/OCA/web/blob/8.0/web_easy_switch_company/view/res_users_view.xml

@LeartS
Copy link

LeartS commented Sep 11, 2014

I did use that file as a reference, that's how I ended up here. I was just
wondering if there's any documentation on that.

@AdilHoumadi AdilHoumadi deleted the 8.0-web_export_view branch November 30, 2014 22:05
JBF91 pushed a commit to JBF91/web that referenced this pull request Nov 14, 2017
[FIX] Fix bad indentation OCA#27 (comment)
8b5b3d1
JBF91 pushed a commit to JBF91/web that referenced this pull request Nov 14, 2017
[FIX] : see => OCA#27 (diff)
94473e5
JBF91 pushed a commit to JBF91/web that referenced this pull request Nov 14, 2017
[FIX] Fix bad indentation OCA#27 (comment)
43affed
JBF91 pushed a commit to JBF91/web that referenced this pull request Nov 14, 2017
[FIX] : see => OCA#27 (diff)
d60c818
mstuttgart pushed a commit to multidadosti-erp/web that referenced this pull request Mar 15, 2018
@mstuttgart
[FIX] Fix bad indentation OCA#27 (comment)
20bea6c
mstuttgart pushed a commit to multidadosti-erp/web that referenced this pull request Mar 15, 2018
@mstuttgart
[FIX] : see => OCA#27 (diff)
9a6aa73
BT-fgarbely pushed a commit to BT-fgarbely/web that referenced this pull request Apr 3, 2018
@bt-admin
Merge pull request OCA#27 from OCA/10.0
45f4a8f 
Syncing from upstream OCA/web (10.0)
leemannd pushed a commit to camptocamp/web that referenced this pull request May 29, 2018
Merge pull request OCA#27 from cyrilgdn/scenario_pricelist
be947fe 
setup: fixing users groups for pricelist visibility
vrenaville pushed a commit to camptocamp/web that referenced this pull request Jul 19, 2018
@gurneyalex
Merge pull request OCA#27 from leemannd/bsmts69
c7d1ff8 
bsmts89 - Data project_task_type
phongdao pushed a commit to phongdao/web that referenced this pull request Jan 17, 2020
@mgielissen
Merge pull request OCA#27 from IOAyman/patch-1
9b3ee22 
Rename __openerp__.py to __manifest__.py
davidtranhp pushed a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
@mgielissen @royle-vietnam
Merge pull request OCA#27 from IOAyman/patch-1
1636b68 
Rename __openerp__.py to __manifest__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AdilHoumadi @coveralls @rvalyi @hbrunn @LeartS @eLBati