[17.0][MIG] web_tree_many2one_clickable #2780

maciej-wichowski · 2024-03-22T13:13:27Z

No description provided.

Clickable many2one fields for tree views ======================================== This addon provides a separate widget to allow many2one fields in a tree view open the linked resource when clicking on their name. You can also define a system parameter to have this behaviour for all the existing many2one fields in tree views. Installation ============ Install it the regular way. Configuration ============= If you want to have all many2one fields clickable by default, you have to define in *Configuration > Technical > Parameters > System parameters*, a new parameter with name `web_tree_many2one_clickable.default` and with value `true`. Usage ===== For the widget option, you need to add `widget="many2one_clickable"` attribute in the XML field definition in the tree view. For example: `<field name="partner_id" widget="many2one_clickable" />` will open the linked partner in a form view. Known issues / Roadmap ====================== * You cannot deactivate clickable behaviour for an specific many2one field if you configure the system parameter. * The value of the system parameter is retrieved for each many2one field present in the view instead of only once.

If a list contains a node which is not a field (e.g. a button), it will not be found in the fields so we'll have an error trying to get 'type' from undefined.

Includes some manual fixes to silent ESLint warnings.

When for instance a form_view_ref context is defined on a field in a specific tree view, the context should also be passed when opening the form.

Clicking on a field with context like this `{'default_product_id': product_id}` doesn't throws an error.

SirAionTech

Thanks for the PR!
I tried this locally and works good.

Could you please squash the bots' commits as shown in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

[MIG] web_tree_many2one_clickable: Migration to 16.0 [MIG] web_tree_many2one_clickable: Migration to 16.0 [MIG] web_tree_many2one_clickable: Migration to 16.0

maciej-wichowski · 2024-03-28T13:09:24Z

Thank you @SirAionTech . Squashed, i hope I got it right 👍

jaronemo · 2024-03-31T14:29:02Z

I tested this code and it doesn't seem to work on the purchase order. DashBoard Error will occur

maciej-wichowski · 2024-04-01T10:47:07Z

Looks like we cannot attach component to ListRenderer directly, because it's not included in custom list renderers like PurchaseDashBoardRenderer.
None of the options below work:

Object.assign(ListRenderer.components, {TreeMany2oneClickableButton});

patch(ListRenderer.prototype, {
    components: {...ListRenderer.components, TreeMany2oneClickableButton},
}

Thus I found a workaround by patching ListRenderer. @SirAionTech , @jaronemo please review again.

edlopen · 2024-04-02T09:39:27Z

Hi @maciej-wichowski ! I have tried it in runbot and works great. Also I've checked that works on Purchase tree too.

Thank you for the PR!

SirAionTech

Tried on runboat this time, still works good 😄

maciej-wichowski · 2024-04-08T14:49:39Z

/ocabot migration web_tree_many2one_clickable

OCA-git-bot · 2024-04-08T14:49:58Z

Sorry @maciej-wichowski you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

bizzappdev

LGTM
Code and Functional test both

OCA-git-bot · 2024-04-19T13:51:21Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2024-04-20T22:39:38Z

/ocabot migration web_tree_many2one_clickable

pedrobaeza

Working correctly on runboat. Just the co-author issue for merging it.

pedrobaeza · 2024-04-20T22:40:25Z

web_tree_many2one_clickable/__manifest__.py

    "category": "Hidden",
    "website": "https://github.com/OCA/web",
    "author": "Therp BV, "
    "Tecnativa, "
    "Camptocamp, "
    "Onestein, "
+    "Versada, "


This migration doesn't qualify for being co-author. Just add you as contributor.

maciej-wichowski · 2024-04-22T06:44:24Z

Thank you @pedrobaeza , corrected.

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-04-22T06:48:41Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2780-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2024-04-22T06:52:52Z

Congratulations, your PR was merged at a480805. Thanks a lot for contributing to OCA. ❤️

pedrobaeza and others added 19 commits March 22, 2024 12:35

[FIX] Allow set web_tree_many2one_clickable.default as True

6eac769

support reference fields in many2one_clickable widget

b1b5667

[MIG] web_tree_many2one_clickable: Migration to 9.0

b05e933

[MIG] web_tree_many2one_clickable: Migrated to 10.0

fa7e920

[MIG] web_tree_many2one_clickable: Migration to 11.0

5c7856d

web_tree_many2one_clickable: Check if the node is a field

dbdd7fc

If a list contains a node which is not a field (e.g. a button), it will not be found in the fields so we'll have an error trying to get 'type' from undefined.

[MIG] web_tree_many2one_clickable: Migration to 12.0.

30e785c

[MIG] web_tree_many2one_clickable: Migration to 12.0

f67904f

[IMP] web_tree_many2one_clickable: Readme - USAGE

2f23934

Added translation using Weblate (Chinese (Simplified))

58074d3

[IMP] web_tree_many2one_clickable: black, isort

e50e471

[MIG] web_tree_many2one_clickable: Migration to 13.0

de55827

[IMP] pre-commit run after update

a39454d

Includes some manual fixes to silent ESLint warnings.

pre-commit update: prettier xml indent

431dfe4

[MIG] web_tree_many2one_clickable: Migration to 14.0

e807111

[MOD] Pass context defined on tree view field

8f16b9d

When for instance a form_view_ref context is defined on a field in a specific tree view, the context should also be passed when opening the form.

[14.0] [FIX] Clicking on a field with context

e663a86

Clicking on a field with context like this `{'default_product_id': product_id}` doesn't throws an error.

[MIG] web_tree_many2one_clickable: Migration to 15.0

76206b6

maciej-wichowski mentioned this pull request Mar 22, 2024

Migration to version 17.0 #2661

Open

20 tasks

SirAionTech suggested changes Mar 27, 2024

View reviewed changes

CarlosRoca13 and others added 4 commits March 28, 2024 14:06

[IMP] web_tree_many2one_clickable: Fix pre-commit + improve readme

564aa51

[MIG] web_tree_many2one_clickable: Migration to 16.0

b878a1a

[MIG] web_tree_many2one_clickable: Migration to 16.0 [MIG] web_tree_many2one_clickable: Migration to 16.0 [MIG] web_tree_many2one_clickable: Migration to 16.0

Added translation using Weblate (Italian)

b64e906

[IMP] web_tree_many2one_clickable: black, isort, prettier

12bd36f

maciej-wichowski force-pushed the 17.0-mig-web_tree_many2one_clickable-mwi branch from 1f77cf0 to e2cb859 Compare March 28, 2024 13:08

maciej-wichowski requested a review from SirAionTech March 28, 2024 13:09

SirAionTech approved these changes Mar 28, 2024

View reviewed changes

maciej-wichowski requested a review from SirAionTech April 1, 2024 10:47

SirAionTech approved these changes Apr 3, 2024

View reviewed changes

bizzappdev approved these changes Apr 19, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 19, 2024

OCA-git-bot added this to the 17.0 milestone Apr 20, 2024

pedrobaeza requested changes Apr 20, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 20, 2024

maciej-wichowski force-pushed the 17.0-mig-web_tree_many2one_clickable-mwi branch from 8b2166a to bb2d92a Compare April 22, 2024 06:43

maciej-wichowski requested a review from pedrobaeza April 22, 2024 06:43

maciej-wichowski force-pushed the 17.0-mig-web_tree_many2one_clickable-mwi branch from bb2d92a to 2ce565e Compare April 22, 2024 06:46

[17.0][MIG] web_tree_many2one_clickable

6334d0a

pedrobaeza approved these changes Apr 22, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 22, 2024

maciej-wichowski force-pushed the 17.0-mig-web_tree_many2one_clickable-mwi branch from 2ce565e to 6334d0a Compare April 22, 2024 06:48

OCA-git-bot added a commit that referenced this pull request Apr 22, 2024

Merge PR #2780 into 17.0

b8e89d8

Signed-off-by pedrobaeza

OCA-git-bot added the bot is merging ⏳ label Apr 22, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 22, 2024

OCA-git-bot closed this Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] web_tree_many2one_clickable #2780

[17.0][MIG] web_tree_many2one_clickable #2780

maciej-wichowski commented Mar 22, 2024

SirAionTech left a comment

maciej-wichowski commented Mar 28, 2024

jaronemo commented Mar 31, 2024

maciej-wichowski commented Apr 1, 2024

edlopen commented Apr 2, 2024

SirAionTech left a comment

maciej-wichowski commented Apr 8, 2024

OCA-git-bot commented Apr 8, 2024

bizzappdev left a comment

OCA-git-bot commented Apr 19, 2024

pedrobaeza commented Apr 20, 2024

pedrobaeza left a comment

pedrobaeza Apr 20, 2024

maciej-wichowski commented Apr 22, 2024

pedrobaeza left a comment

OCA-git-bot commented Apr 22, 2024

OCA-git-bot commented Apr 22, 2024

[17.0][MIG] web_tree_many2one_clickable #2780

[17.0][MIG] web_tree_many2one_clickable #2780

Conversation

maciej-wichowski commented Mar 22, 2024

SirAionTech left a comment

Choose a reason for hiding this comment

maciej-wichowski commented Mar 28, 2024

jaronemo commented Mar 31, 2024

maciej-wichowski commented Apr 1, 2024

edlopen commented Apr 2, 2024

SirAionTech left a comment

Choose a reason for hiding this comment

maciej-wichowski commented Apr 8, 2024

OCA-git-bot commented Apr 8, 2024

bizzappdev left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 19, 2024

pedrobaeza commented Apr 20, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

pedrobaeza Apr 20, 2024

Choose a reason for hiding this comment

maciej-wichowski commented Apr 22, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 22, 2024

OCA-git-bot commented Apr 22, 2024