Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] web_responsive: disable default file preview #2795

Merged
merged 1 commit into from
Apr 19, 2024
Merged

[17.0][FIX] web_responsive: disable default file preview #2795

merged 1 commit into from
Apr 19, 2024

Conversation

LazarusUA
Copy link

@LazarusUA LazarusUA commented Apr 14, 2024 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

Hi @Tardo, @yajo, @SplashS,
some modules you are maintaining are being modified, check this out!

@LazarusUA LazarusUA mentioned this pull request Apr 14, 2024
Closed
@pedrobaeza pedrobaeza added this to the 17.0 milestone Apr 19, 2024
pedrobaeza
pedrobaeza approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, thanks!

/ocabot merge patch

@pedrobaeza pedrobaeza linked an issue Apr 19, 2024 that may be closed by this pull request
[17.0] web_responsive: Main document preview is activated by default #2745
Closed
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2795-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6efeafc into OCA:17.0 Apr 19, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8f3c6d5. Thanks a lot for contributing to OCA. ❤️

@cvinh
Copy link
Contributor

cvinh commented Apr 27, 2024

Hello
We have a accountant customer who liked the attachment automatically opened in supplier invoices (for reviewing quickly)
Humm, it would be better to have a setup by user... what do you think ?
Best regards

@pedrobaeza
Copy link
Member

You can propose a pull request adding such option.

@legalsylvain
Copy link
Contributor

Humm, it would be better to have a setup by user... what do you think ?

A per user option looks great.

@duyquyen96 duyquyen96 mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.

[17.0] web_responsive: Main document preview is activated by default
5 participants
@LazarusUA @OCA-git-bot @cvinh @pedrobaeza @legalsylvain