Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_widget_bokeh_chart #2846

Merged
merged 54 commits into from
Jun 14, 2024

Conversation

DavidJForgeFlow
Copy link
Contributor

@DavidJForgeFlow DavidJForgeFlow commented Jun 13, 2024

Migration to 17.0

Supersede #2805

Also updates bokeh lib from 3.1.1 to 3.4.1 to include the fix like #2793

@ForgeFlow

LoisRForgeFlow and others added 30 commits June 13, 2024 12:32
Includes some manual fixes to silent ESLint warnings.
@LoisRForgeFlow
Copy link
Contributor

cc @robyf70 you might want to review this one

Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update bokeh from 3.1.1 to 3.4.1
@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-mig-web_widget_bokeh_chart branch from 582fc03 to cef27bc Compare June 13, 2024 11:43
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

1 similar comment
@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @LoisRForgeFlow you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

1 similar comment
@OCA-git-bot
Copy link
Contributor

Sorry @LoisRForgeFlow you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-2846-by-etobella-bump-nobump, awaiting test results.

@etobella
Copy link
Member

/ocabot migration web_widget_bokeh_chart

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 14, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2024
19 tasks
@OCA-git-bot OCA-git-bot merged commit 1e9f34f into OCA:17.0 Jun 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3e7301b. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 17.0-mig-web_widget_bokeh_chart branch June 14, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet