Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "web_list_html_widget" module #42

Merged
merged 2 commits into from Nov 3, 2014

Conversation

OSguard
Copy link

@OSguard OSguard commented Sep 22, 2014

This module allows to use a widget="html" for fields in
list(tree) views.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 877bb98 on initOS:7.0-add_web_list_html_widget into 4e3098f on OCA:7.0.

@pedrobaeza
Copy link
Member

Some questions:

  • It is possible/advisable to sanitize first HTML?
  • Have you tried to propose this to core?

Regards

@OSguard
Copy link
Author

OSguard commented Sep 22, 2014

It is the same behavior as HTML.fields in form view
And the module is from the pre Github times, as our MR was ignored, so we build modules if it is possible to ship it ;) - And yet not retry again.

@hbrunn
Copy link
Member

hbrunn commented Oct 6, 2014

I think the warning in the manifest suffices. If you deal with anything the remotely comes from external input, you'll wrap this in a function field that does the sanitizing I'd say. 👍

@legalsylvain legalsylvain added this to the 7.0 milestone Oct 14, 2014
@max3903
Copy link
Sponsor Member

max3903 commented Oct 24, 2014

Can you generate the translation file so the description could be translated ?

Otherwise LGTM

@OSguard
Copy link
Author

OSguard commented Oct 25, 2014

done

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6eec563 on initOS:7.0-add_web_list_html_widget into 4e3098f on OCA:7.0.

hbrunn added a commit that referenced this pull request Nov 3, 2014
@hbrunn hbrunn merged commit 00593a5 into OCA:7.0 Nov 3, 2014
BT-fgarbely pushed a commit to BT-fgarbely/web that referenced this pull request Apr 3, 2018
Syncing from upstream OCA/web (10.0)
leemannd pushed a commit to camptocamp/web that referenced this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants