[ADD][web_editor_background_color] Custom background color picker #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addon lets the user choose a preferred background color when editing some web content. Works out of the box with `website` and `mass_mailing` addons, although requires none of those.
31 tasks
tarteo
requested changes
Mar 15, 2017
There was a problem hiding this comment.
Hey @yajo
I tested it on runbot:
- I tried to select a color in the color picker (by clicking on the color pallet): The background wouldn't change to the color I selected; it kept changing it to white. It works though when I select the text field, type in any character (the menu closes and the background color changes to black), reopen the menu and then select the color on the pallet.
- The color presets works.
Code:
- Looks very good. It's easy to read and has some nice inline documentation!
I'm using Google Chrome 56.0.2924.87.
|
Thanks @tarteo, could you upload a screencast to see exactly what's happening? |
|
@yajo |
This happened specifically in Chrome as demonstrated in OCA#582 (comment).
|
@tarteo It should work now. I did not notice because I mainly use Firefox. Merger: remember to squash on merge 😊 |
moylop260
reviewed
Mar 16, 2017
| var style = this.$target.prop("style"); | ||
| this.change_border = | ||
| style["border-color"] && | ||
| style["background-color"] == style["border-color"]; |
moylop260
approved these changes
Mar 16, 2017
|
@moylop260 Fixed. 4x 👍 now. Please merge 🙌 😊 |
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Jul 5, 2017
…A#582) * [ADD][web_editor_background_color] Custom background color picker This addon lets the user choose a preferred background color when editing some web content. Works out of the box with `website` and `mass_mailing` addons, although requires none of those. * [FIX] Avoid clicks removing dropdown menu This happened specifically in Chrome as demonstrated in OCA#582 (comment). * [FIX] Use strict equality operator.
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Oct 11, 2018
…A#582) * [ADD][web_editor_background_color] Custom background color picker This addon lets the user choose a preferred background color when editing some web content. Works out of the box with `website` and `mass_mailing` addons, although requires none of those. * [FIX] Avoid clicks removing dropdown menu This happened specifically in Chrome as demonstrated in OCA#582 (comment). * [FIX] Use strict equality operator.
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Jul 9, 2019
…A#582) * [ADD][web_editor_background_color] Custom background color picker This addon lets the user choose a preferred background color when editing some web content. Works out of the box with `website` and `mass_mailing` addons, although requires none of those. * [FIX] Avoid clicks removing dropdown menu This happened specifically in Chrome as demonstrated in OCA#582 (comment). * [FIX] Use strict equality operator.
daerio
pushed a commit
to vertelab/odoo-oca-web
that referenced
this pull request
Aug 7, 2020
…A#582) * [ADD][web_editor_background_color] Custom background color picker This addon lets the user choose a preferred background color when editing some web content. Works out of the box with `website` and `mass_mailing` addons, although requires none of those. * [FIX] Avoid clicks removing dropdown menu This happened specifically in Chrome as demonstrated in OCA#582 (comment). * [FIX] Use strict equality operator.
CarlosRoca13
pushed a commit
to Tecnativa/web
that referenced
this pull request
Nov 5, 2020
…A#582) * [ADD][web_editor_background_color] Custom background color picker This addon lets the user choose a preferred background color when editing some web content. Works out of the box with `website` and `mass_mailing` addons, although requires none of those. * [FIX] Avoid clicks removing dropdown menu This happened specifically in Chrome as demonstrated in OCA#582 (comment). * [FIX] Use strict equality operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon lets the user choose a preferred background color when editing some web content.
Works out of the box with
websiteandmass_mailingaddons, although requires none of those.😎 Cool
This addon replaces the old
website_mail_snippet_bg_color, and it is completely new.@Tecnativa