[10.0] help_online fix export/import #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This key is required to get the pages properly imported as web pages
JonathanNEMRY
approved these changes
Mar 17, 2017
lasley
approved these changes
Mar 17, 2017
help_online/tests/common.py
Outdated
| @@ -81,6 +81,7 @@ def createPage(self, pageName, imgXmlId=False): | |||
| 'type': 'qweb', | |||
| 'arch': arch, | |||
| 'page': True, | |||
| 'key': 'website.' + pageName | |||
There was a problem hiding this comment.
'website.%s' % pageName in order to handle type conversions
moylop260
approved these changes
Mar 18, 2017
This handles type conversions properly
|
It looks like this module is breaking the build: |
|
moreover, my commit history was clean and should not have been squashed. I don't want to be credited for this 💣 💥 commit. Commits from different authors can't be squashed!!!!! |
|
@yajo Can you fix your mistake PLZ |
lmignon
added a commit
to acsone/web
that referenced
this pull request
Jun 1, 2017
This reverts commit 95f15c4.
|
Yes, @lmignon sorry, will fix ASAP. |
yajo
added a commit
to acsone/web
that referenced
this pull request
Jun 1, 2017
yajo
added a commit
that referenced
this pull request
Jun 1, 2017
apineux
pushed a commit
to acsone/web
that referenced
this pull request
Jul 30, 2021
* [FIX] help_online: Replace obsolete icon into the export wizard * [FIX] help_online: Add the key attribute into the exported data This key is required to get the pages properly imported as web pages * Use the correct method for combining strings This handles type conversions properly
apineux
pushed a commit
to acsone/web
that referenced
this pull request
Jul 30, 2021
This reverts commit 95f15c4.
apineux
pushed a commit
to acsone/web
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.