[10.0] [FIX] [web_timeline] Correct write when grouped by #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @JBF91, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
Thanks for the patch. Please don't add extra blank lines. They don't add anything and make less clear the code read. |
|
And please sign the CLA. |
pedrobaeza
requested changes
Jul 20, 2017
| @@ -283,6 +284,7 @@ odoo.define('web_timeline.TimelineView', function (require) { | |||
| var self = this; | |||
| var data = []; | |||
| var groups = []; | |||
| this.grouped_by = group_bys | |||
| @@ -404,7 +406,9 @@ odoo.define('web_timeline.TimelineView', function (require) { | |||
| time.auto_date_to_str(start, self.fields[self.fields_view.arch.attrs.date_start].type); | |||
| data[self.fields_view.arch.attrs.date_stop] = | |||
| time.auto_date_to_str(end, self.fields[self.fields_view.arch.attrs.date_stop].type); | |||
| data[self.fields_view.arch.attrs.default_group_by] = group; | |||
| if(self.grouped_by){ | |||
There was a problem hiding this comment.
space between if and the expression
| @@ -404,7 +406,9 @@ odoo.define('web_timeline.TimelineView', function (require) { | |||
| time.auto_date_to_str(start, self.fields[self.fields_view.arch.attrs.date_start].type); | |||
| data[self.fields_view.arch.attrs.date_stop] = | |||
| time.auto_date_to_str(end, self.fields[self.fields_view.arch.attrs.date_stop].type); | |||
| data[self.fields_view.arch.attrs.default_group_by] = group; | |||
| if(self.grouped_by){ | |||
| data[self.grouped_by[0]] = group | |||
pedrobaeza
approved these changes
Jul 20, 2017
hbrunn
approved these changes
Aug 17, 2017
Maartincm
pushed a commit
to Maartincm/web
that referenced
this pull request
Apr 13, 2018
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
mstuttgart
pushed a commit
to multidadosti-erp/web
that referenced
this pull request
Apr 26, 2018
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
fmdl
pushed a commit
to fmdl/web
that referenced
this pull request
May 1, 2018
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
yaniaular
pushed a commit
to vauxoo-dev/web
that referenced
this pull request
May 14, 2018
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
yaniaular
pushed a commit
to vauxoo-dev/web
that referenced
this pull request
May 14, 2018
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
tarteo
pushed a commit
to tarteo/web
that referenced
this pull request
Oct 23, 2018
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
thoongnv
pushed a commit
to thoongnv/web
that referenced
this pull request
Dec 30, 2019
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
Tardo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Mar 23, 2020
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
Tardo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Mar 30, 2020
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
Yoshiro009
pushed a commit
to ecosoft-odoo/web
that referenced
this pull request
Nov 17, 2020
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
Murtaza-OSI
pushed a commit
to ursais/web
that referenced
this pull request
Mar 15, 2021
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
cesar-tecnativa
pushed a commit
to Tecnativa/web
that referenced
this pull request
Jul 5, 2022
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
cesar-tecnativa
pushed a commit
to Tecnativa/web
that referenced
this pull request
Jul 5, 2022
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
CarlosRoca13
pushed a commit
to Tecnativa/web
that referenced
this pull request
Aug 2, 2022
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Jan 2, 2023
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Jan 2, 2023
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Mar 1, 2023
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are working with the timeline view and you have grouped your items, you can extend or reduce the time duration of each item, but also change the group they belong, by dragging up or down the record.
I think that changing the group does not work as it should, since is writing the record but having as reference the "default_group_by" defined in the view attrs, instead of the current "group_by" condition defined in the search view box.
I've made a fix and tested myself but just for a while. Hope is useful