[MIG] web_export_view: Migration to 11.0 #798

JBF91 · 2017-11-14T10:22:49Z

A proposal for the Migration of web_export_view to 11.0 . Some notes about the changes and the problems I've found:

Odoo 11.0 changes some attrs in the rendering of HTML. We do not longer have auxiliar attributes like "data-id" or "data-field" very useful in the older "web_export_view" wich uses "data-field" attrs to get the column keys. I've changed it for a column index (fast and ugly workaround, but do the trick).

CONS: Couldn't get the columns Strings in the XLS header, it exports the technical name of the field instead the string.

PD: As @pedrobaeza recommend me I was triying to migrate it with the new 8.0 feature, wich exports all the dataset if all the rows are checked instead of only the first page (just like the odoo export base behaviour) but couldn't find the right way to get all item id's since we don't longer have "data-id".

Changes resume:

Update objects attributes to new JS structure
Update function names (redraw -> _redraw)
Update JQuery selectors to get the list in the CSS classes.

yajo

Code looks good, but no runbot yet to test. Functionally OK too.

Thanks for the good explanation on the migration job, BTW.

Remember to squash all translation commits in one please.

simahawk · 2017-11-14T13:30:42Z

quick tests on runbot by exporting some contacts: works fine ;)

simahawk · 2017-11-14T13:34:05Z

@JBF91 as for the labels, what about these 2 options:

quick n dirty: get the closest TH and grab them by position
call fields_get passing exported fields and collect all fields_info['string']

JBF91 · 2017-11-14T16:47:34Z

I think I've squash properly the translation commits (thanks to @yajo )

@simahawk I've get the title row (quick and dirty way) but dont like the abuse of jQuery selectors. Tried and failed the other way, maybe tomorrow I give it another try.

simahawk · 2017-11-15T07:38:56Z

@JBF91 I see... In any case the whole JS here is kind of a trick ;)

Maybe you can collect fields into self.fieldnames then at the end you can wrap the call to the controller into something like this:

this._rpc({
  model: view.modelName,
  method: 'fields_get',
  args: [self.fieldnames],
}).done(function (export_fields) {
  session.get_file({
    url: '/web/export/xls_view',
    data: {data: JSON.stringify({
        model: view.modelName,
        headers: _.map(export_fields, function(field){ return field['string']; }),
        rows: export_rows
    })},
    complete: $.unblockUI
  });
})

kind of... :)

Anyway, you have a "plan B" in case the JS fails: if you still send the header as field names you can call fields_get on controller side and inject the 1st line before calling xls creation.

yajo

code ok

benwillig

Code review and test 👍

pedrobaeza · 2018-03-01T08:32:49Z

Is this exporting the whole set or not yet? It's important to keep that behavior, as Odoo export works that way and now people expect this also to work that way.

hbrunn · 2018-03-01T08:38:50Z

I hacked the all records export into 8 in #785, and then had to fix a lot of stuff in https://github.com/OCA/web/pull/816/files in case that helps (probably won't given the js changes)

okuryan · 2018-03-09T10:53:50Z

What is progress on this migration?

JBF91 · 2018-03-09T11:16:15Z

@okuryan Well this was working fine (two months ago) afaik, just a thing that @pedrobaeza suggested, to add an extra feature that exports all records (everypage) if all the records in the main page are selected.

(Don't know if that's a good idea, to give every user who has access to a list of records exports it so easily, you already have base export functionality for that.)

fr33co · 2018-03-23T16:38:47Z

I fix the column problem with this (11.0 Enterprise):

export_columns_names.push(view.$el.find('.o_list_view > thead > tr > .o_column_sortable:eq('+column_index+')')[0].textContent);

Change th[title] with .o_column_sortable:eq

CasVissers-360ERP · 2018-04-18T09:49:46Z

Module works when exporting as admin but results in a traceback when exporting as a user:

`Error:
TypeError: view.$el.find(...)[0] is undefined

https://customer.com/web/content/32110-3cbb18d/web.assets_backend.js:3395
Traceback:
on_sidebar_export_treeview_xls/<@https://customer.com/web/content/32110-3cbb18d/web.assets_backend.js:3395:264
each@https://customer.com/web/content/32058-c463c92/web.assets_common.js:625:758
on_sidebar_export_treeview_xls@https://customer.com/web/content/32110-3cbb18d/web.assets_backend.js:3395:75
dispatch@https://customer.com/web/content/32058-c463c92/web.assets_common.js:892:378
add/elemData.handle@https://customer.com/web/content/32058-c463c92/web.assets_common.js:865:151`

EDIT:
The fix by @fr33co fixes this issue.

CasVissers-360ERP · 2018-04-25T09:54:25Z

While exporting the list view generated by the OCA tax balance module:

Fout:
TypeError: view.$el.find(...)[0] is undefined

https://customer.com/web/content/33266-43b409b/web.assets_backend.js:3395
Traceback:
on_sidebar_export_treeview_xls/<@https://customer.com/web/content/33266-43b409b/web.assets_backend.js:3395:264
each@https://customer.com/web/content/32058-c463c92/web.assets_common.js:625:758
on_sidebar_export_treeview_xls@https://customer.com/web/content/33266-43b409b/web.assets_backend.js:3395:75
dispatch@https://customer.com/web/content/32058-c463c92/web.assets_common.js:892:378
add/elemData.handle@https://customer.com/web/content/32058-c463c92/web.assets_common.js:865:151

yajo · 2018-04-25T10:34:32Z

Please send useful tracebacks: https://github.com/odoo/odoo/wiki/Contributing#tracebacks

benwillig · 2018-05-17T12:42:14Z

web_export_view/static/src/js/web_export_view.js

+                if (this.tag == 'field' && (this.attrs.widget === undefined || this.attrs.widget != 'handle')) {
+                    // non-fields like `_group` or buttons
+                    export_columns_keys.push(column_index);
+                    export_columns_names.push(view.$el.find('.o_list_view > thead > tr> th[title]:eq('+column_index+')')[0].textContent);


I found out this selector only works in debug mode.
I fixed it here acsone@bf97999
I'm not able to push on your repo @JBF91 but you can cherry pick my commit.
This commit also fixes errors when a column is not sortable, this is related to last @CasVissers reported error.

JBF91 · 2018-05-18T06:37:37Z

Few tests passed, everything OK with @benwillig commit cherry picked.

benwillig · 2018-05-28T07:28:29Z

I pushed an other commit here acsone@88f0e42. When exporting, numbers formatted with a float time widget are changed from '01:00' to '0100', this commit fixes this behavior.

MeetKD · 2018-05-30T19:52:33Z

web_export_view/static/src/js/web_export_view.js

+                    headers: export_columns_names,
+                    rows: export_rows
+                })},
+                complete: $.unblockUI


Can you please add error handler ?
error: c.rpc_error.bind(c),
'c' will be crash manager.

Any fast way of testing the error binding?

May b you can raise a warning or traceback from /web/export/xls_view route and it will be handled via crashmanager => error: c.rpc_error.bind(c)

antoniocanovas

Functional review Ok.

JBF91 · 2018-07-09T06:55:42Z

As @MeetKD recommended, added CrashManager. I think this is ready to merge.

yajo

It seems you accidentally introduced a lint error.

yajo · 2018-07-23T08:34:40Z

web_export_view/controllers/controllers.py

@@ -7,6 +7,7 @@
 import json
 import odoo.http as http
 from odoo.http import request
+from odoo import exceptions


🔥 not needed

angelmoya · 2018-07-30T11:35:06Z

Tested local and works ok.

I don't if someone else have this little issue, but I need to restart Odoo because list view get a javascript error

CasVissers-360ERP

LGTM

* Compatibility with Werkzeug 0.9.3 * Export of first one2many field works again * Parsing of float values

… a thousand separator is used.

… with the original index used in the native excel export

Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.

* Retrieve all columns even if they are not sortable. Prevent to get select record column * Prevent to process float time numbers as real numbers during the export

pedrobaeza · 2018-08-15T15:26:14Z

As there's no better option for now than exporting what is shown in the view, let's continue with the merge.

richard-willdooit · 2018-08-16T22:46:07Z

We have been using it for a short while now in a production environment with no noticeable issues.

JBF91 mentioned this pull request Nov 14, 2017

Migration to version 11.0 #739

Closed

68 tasks

JBF91 force-pushed the 11.0-web_export_view branch from 9a6d554 to a851831 Compare November 14, 2017 12:07

yajo added the needs review label Nov 14, 2017

yajo added this to the 11.0 milestone Nov 14, 2017

yajo approved these changes Nov 14, 2017

View reviewed changes

simahawk approved these changes Nov 14, 2017

View reviewed changes

JBF91 force-pushed the 11.0-web_export_view branch from a851831 to f17bcda Compare November 14, 2017 16:37

yajo approved these changes Nov 15, 2017

View reviewed changes

benwillig approved these changes Mar 1, 2018

View reviewed changes

benwillig suggested changes May 17, 2018

View reviewed changes

benwillig approved these changes May 18, 2018

View reviewed changes

MeetKD suggested changes May 30, 2018

View reviewed changes

antoniocanovas approved these changes May 30, 2018

View reviewed changes

CasVissers-360ERP approved these changes Jun 4, 2018

View reviewed changes

yajo requested changes Jul 23, 2018

View reviewed changes

CasVissers-360ERP approved these changes Aug 15, 2018

View reviewed changes

Leonardo Pistone and others added 20 commits August 15, 2018 16:29

[add] module web_export_view copied from 6.1

d6ee226

[add] port web_export_view to OpenERP 7

5327689

[FIX] Convert number string to number

ad89a6a

[FIX] web_export_view: Several things:

d7276a4

* Compatibility with Werkzeug 0.9.3 * Export of first one2many field works again * Parsing of float values

[FIX] don't show export format for current view in export list

bf5b02d

[ADD] pot file + Dutch and German translation

8e783fc

[ADD] Add FR translation for 'web_export_view' module

1fa36c5

[FIX] now export only selected items.

9d43c7a

Launchpad automatic translations update.

a0b70b7

[web_export_view]: fixes export boolean fields

a77212b

Migrate web_export_view to v 8.0

093b023

Small fix to allow integers to be parsed correctly when a locate with…

917d49a

… a thousand separator is used.

[FIX] web_export_view: Handler method renamed to avoid name collision…

85ef469

… with the original index used in the native excel export

Handle the thousands separator, even multiple ones.

f06e69a

Slovene translations and translation template

66af04f

[MIG 10.0] web_export_view (OCA#444)

be736df

OCA Transbot updated translations from Transifex

b97b8d2

[FIX][web_export_view] Remove monetary formatting (OCA#594)

7c40582

Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.

[MIG] web_export_view: Migration to 11.0

e770e46

[FIX] web_export_view: Several things:

a4e4079

* Retrieve all columns even if they are not sortable. Prevent to get select record column * Prevent to process float time numbers as real numbers during the export

pedrobaeza force-pushed the 11.0-web_export_view branch from 0686557 to 14eb14c Compare August 15, 2018 14:42

[ADD] Crash Manager

9662e81

pedrobaeza force-pushed the 11.0-web_export_view branch from 14eb14c to 9662e81 Compare August 15, 2018 15:01

pedrobaeza merged commit 9139f87 into OCA:11.0 Aug 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] web_export_view: Migration to 11.0 #798

[MIG] web_export_view: Migration to 11.0 #798

JBF91 commented Nov 14, 2017

yajo left a comment •

edited

Loading

simahawk commented Nov 14, 2017

simahawk commented Nov 14, 2017

JBF91 commented Nov 14, 2017

simahawk commented Nov 15, 2017 •

edited

Loading

yajo left a comment

benwillig left a comment

pedrobaeza commented Mar 1, 2018

hbrunn commented Mar 1, 2018

okuryan commented Mar 9, 2018

JBF91 commented Mar 9, 2018

fr33co commented Mar 23, 2018 •

edited

Loading

CasVissers-360ERP commented Apr 18, 2018 •

edited

Loading

CasVissers-360ERP commented Apr 25, 2018 •

edited

Loading

yajo commented Apr 25, 2018

benwillig May 17, 2018 •

edited

Loading

JBF91 commented May 18, 2018

benwillig commented May 28, 2018

MeetKD May 30, 2018

JBF91 Jun 11, 2018

MeetKD Jun 15, 2018

antoniocanovas left a comment

JBF91 commented Jul 9, 2018

yajo left a comment •

edited

Loading

yajo Jul 23, 2018

angelmoya commented Jul 30, 2018

CasVissers-360ERP left a comment

pedrobaeza commented Aug 15, 2018

richard-willdooit commented Aug 16, 2018

[MIG] web_export_view: Migration to 11.0 #798

[MIG] web_export_view: Migration to 11.0 #798

Conversation

JBF91 commented Nov 14, 2017

yajo left a comment • edited Loading

Choose a reason for hiding this comment

simahawk commented Nov 14, 2017

simahawk commented Nov 14, 2017

JBF91 commented Nov 14, 2017

simahawk commented Nov 15, 2017 • edited Loading

yajo left a comment

Choose a reason for hiding this comment

benwillig left a comment

Choose a reason for hiding this comment

pedrobaeza commented Mar 1, 2018

hbrunn commented Mar 1, 2018

okuryan commented Mar 9, 2018

JBF91 commented Mar 9, 2018

fr33co commented Mar 23, 2018 • edited Loading

CasVissers-360ERP commented Apr 18, 2018 • edited Loading

CasVissers-360ERP commented Apr 25, 2018 • edited Loading

yajo commented Apr 25, 2018

benwillig May 17, 2018 • edited Loading

Choose a reason for hiding this comment

JBF91 commented May 18, 2018

benwillig commented May 28, 2018

MeetKD May 30, 2018

Choose a reason for hiding this comment

JBF91 Jun 11, 2018

Choose a reason for hiding this comment

MeetKD Jun 15, 2018

Choose a reason for hiding this comment

antoniocanovas left a comment

Choose a reason for hiding this comment

JBF91 commented Jul 9, 2018

yajo left a comment • edited Loading

Choose a reason for hiding this comment

yajo Jul 23, 2018

Choose a reason for hiding this comment

angelmoya commented Jul 30, 2018

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 15, 2018

richard-willdooit commented Aug 16, 2018

yajo left a comment •

edited

Loading

simahawk commented Nov 15, 2017 •

edited

Loading

fr33co commented Mar 23, 2018 •

edited

Loading

CasVissers-360ERP commented Apr 18, 2018 •

edited

Loading

CasVissers-360ERP commented Apr 25, 2018 •

edited

Loading

benwillig May 17, 2018 •

edited

Loading

yajo left a comment •

edited

Loading