-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig web search with and #895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small glitches and a question
web_search_with_and/__init__.py
Outdated
@@ -0,0 +1 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop coding headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OpenCode ping :)
web_search_with_and/__manifest__.py
Outdated
'author': 'Versada UAB, Odoo Community Association (OCA)', | ||
'license': 'AGPL-3', | ||
'category': 'web', | ||
'website': 'http://www.versada.lt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web_search_with_and/__manifest__.py
Outdated
'data/data.xml', | ||
], | ||
'installable': True, | ||
'application': False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this
}); | ||
|
||
SearchView.SearchQuery.prototype = SearchView.SearchQuery.extend({ | ||
// Override the odoo method to (conditionally) add a search facet even if a existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we use include
+ _super
here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simahawk where I can find documentation about include and _super?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of lines above? 😄
I'm just guessing. Maybe the original author did it like that for a reason and maybe now is no more needed... You can try 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it. It seems that it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a comment about this here (2 lines down):
// The prototype is used to override the 'add' function in order to execute the
// following code before the Odoo native override (trick)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarteo well, I saw it but I was wondering if it was still the case 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simahawk Oh ok haha ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and local test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Ok
* Francesco Apruzzese <f.apruzzese@apuliasoftware.it> | ||
|
||
Maintainer | ||
---------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace http by https in all sections down under.
Hi @OpenCode could you update with comment of @JayVora-SerpentCS Thanks |
@simahawk @JayVora-SerpentCS It's ok, now? |
@fmdl Done! |
Add README.rst Too short underline for module title in README.rst Improving module meta information Version 1.0 W391 blank line at end of file Remove module description because README.rst is there web_search_with_and: Latest OCA conventions
b9bbe45
to
528c9b4
Compare
No description provided.