Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig web search with and #895

Merged
merged 3 commits into from
May 25, 2018

Conversation

OpenCode
Copy link
Contributor

No description provided.

@OpenCode OpenCode mentioned this pull request Mar 20, 2018
68 tasks
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small glitches and a question

@@ -0,0 +1 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop coding headers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OpenCode ping :)

'author': 'Versada UAB, Odoo Community Association (OCA)',
'license': 'AGPL-3',
'category': 'web',
'website': 'http://www.versada.lt',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'data/data.xml',
],
'installable': True,
'application': False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this

});

SearchView.SearchQuery.prototype = SearchView.SearchQuery.extend({
// Override the odoo method to (conditionally) add a search facet even if a existing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we use include + _super here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk where I can find documentation about include and _super?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of lines above? 😄
I'm just guessing. Maybe the original author did it like that for a reason and maybe now is no more needed... You can try 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it. It seems that it doesn't work.

Copy link
Member

@tarteo tarteo Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a comment about this here (2 lines down):

// The prototype is used to override the 'add' function in order to execute the
// following code before the Odoo native override (trick)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarteo well, I saw it but I was wondering if it was still the case 😜

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk Oh ok haha ;)

@pedrobaeza pedrobaeza added this to the 11.0 milestone Mar 21, 2018
Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and local test

Copy link

@felixvillafranca felixvillafranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Ok

* Francesco Apruzzese <f.apruzzese@apuliasoftware.it>

Maintainer
----------
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace http by https in all sections down under.

@fmdl
Copy link
Contributor

fmdl commented May 1, 2018

Hi @OpenCode could you update with comment of @JayVora-SerpentCS

Thanks

@OpenCode
Copy link
Contributor Author

@simahawk @JayVora-SerpentCS It's ok, now?

@OpenCode
Copy link
Contributor Author

@fmdl Done!

Andrius Preimantas and others added 3 commits May 25, 2018 17:55
Add README.rst

Too short underline for module title in README.rst

Improving module meta information

Version 1.0

W391 blank line at end of file

Remove module description because README.rst is there

web_search_with_and: Latest OCA conventions
@pedrobaeza pedrobaeza force-pushed the 11.0-mig-web_search_with_and branch from b9bbe45 to 528c9b4 Compare May 25, 2018 15:55
@pedrobaeza pedrobaeza merged commit c2ebb9e into OCA:11.0 May 25, 2018
@OpenCode OpenCode deleted the 11.0-mig-web_search_with_and branch May 29, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants