Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig web_listview_range_select #910

Merged

Conversation

aldo774
Copy link
Member

@aldo774 aldo774 commented Apr 11, 2018

Migration of the web_listview_range_select module to v11

@aldo774 aldo774 mentioned this pull request Apr 11, 2018
68 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Apr 11, 2018
Copy link
Member

@mstuttgart mstuttgart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working! Thanks 👍

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migrating. I tested it on Runbot and it works perfectly.


.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/162/10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to 11.0

'version': '11.0.1.0.0',
'category': 'Web',
'author': 'Onestein,Odoo Community Association (OCA)',
'website': 'http://www.onestein.eu',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the website to https://github.com/oca/web, please.

@@ -0,0 +1,59 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the README to comply the new template.

@aldo774 aldo774 force-pushed the 11.0-mig-web_listview_range_select branch 2 times, most recently from eaf57eb to 5fc32cb Compare April 13, 2018 19:37
@aldo774
Copy link
Member Author

aldo774 commented Apr 13, 2018

Changes maded 👍

Copy link
Member

@rodrigets rodrigets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot 👍

Please @tarteo review you review 😄 Thanks!

@pedrobaeza pedrobaeza force-pushed the 11.0-mig-web_listview_range_select branch from 5fc32cb to 856a0b8 Compare April 16, 2018 08:16
@pedrobaeza pedrobaeza merged commit cb1f5b3 into OCA:11.0 Apr 16, 2018
@mstuttgart mstuttgart deleted the 11.0-mig-web_listview_range_select branch April 16, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants