Add webkit setup module #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't better to have this configuration as a permanent parameter in configuration instead of a wizard? |
|
the wizard is to easy find the correct value for "webkit_path" and store it to "ir.config_parameter" |
|
I am not enthusiastic about adding application code to do server configuration. I'm not blocking it though. Thanks! |
|
Its server configuration, but ir.parameters is not in DB ? Wizard is helping to do this. |
|
Travis is still red and no further development, so I close this. If there's still interest in this, feel free to open a new PR fixing Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows to configure the webkit path by a wizard during setup.
All wkhtmltopdf binaries in the PATH will be suggested in the wizard
drop down field.